search

venmo / VENTouchLock

A Touch ID and Passcode framework used in the Venmo app.
MIT License
964 stars 114 forks source link

iOS 11 Issue with TouchID #89

Closed lewis-smith closed 7 years ago

lewis-smith commented 7 years ago

I am testing my app in iOS 11 and I found an issue in VENTouchLock.

When the app enters the background it calls [self lock] which in turn brings up the Touch ID prompt.

In iOS 10 and earlier the Touch ID screen would load inside the app and the user doesn't see it until they bring the app to the foreground. In iOS 11 beta 4 the Touch ID screen opens in the main window as soon the app is in the background.

If you authorise at that point then when the app comes to the foreground it is already unlocked.

I've made a video to explain it better. I can investigate a fix for this, but as the authors of this module I assume you will do a better job :)

2017-08-12 14 14 14

lewis-smith commented 7 years ago

I tested this in the sample app and it was fine.

For some reason my version of the code for the file VENTouchLock/VENTouchLock/Controllers/VENTouchLockSplashViewController.m was out of date. I'm not sure how this happened as I am using cocoa pods, but with the latest code there is no issue.