veracrypt / VeraCrypt

Disk encryption with strong security based on TrueCrypt
https://www.veracrypt.fr
Other
6.8k stars 940 forks source link

VeraCrypt Improvement #1009

Open wendig0x opened 1 year ago

wendig0x commented 1 year ago

Hi

@idrassi, I researched the source code of VeraCrypt a bit, I suggest the following fixes and improvements:

  1. when collecting entropy from mouse movements, you need to make the NEXT button inactive until the entropy is collected
  2. update zlib, libzip, JitterEntropy to latest version
  3. increase the number of PBKDF iterations from 500,000 to 1,000,000
  4. make random selection of cipher/hash when opening CIPHER_PAGE (need to drop the default values)
  5. fix memory encryption (MSR or Dr0-7)
  6. add BLACK algorithm in HMAC mode
  7. add KDF Argon2id for non-system encryption
  8. before encryption, add a window displaying all encryption parameters (hash, encryption algorithm, PIM)
  9. add support for journaled file systems to monitor the integrity of data in the container
  10. use the Fortuna PRNG

I recommend doing a pull request according to the rule "one pullrequest - one fix". This will make it easier to look for bugs.

I can help with the implementation, but let's discuss these guidelines first

alt3r-3go commented 1 year ago

Same as [not] bundling the fixes into commits, it would probably be better to have separate issues for each of the above. Unless they are accepted or rejected in bulk, the discussion on specific points may become unwieldy.

fzxx commented 1 year ago

@idrassi @wendig0x @alt3r-3go Another branch of Truecrypt, Cncrypt, which has many features can also be found (see attachment) The author of Cncrypt has not had time to update the software, but the official domain is still his. Cncrypt.zip

BigPanda97 commented 1 year ago

@idrassi @wendig0x @alt3r-3go Another branch of Truecrypt, Cncrypt, which has many features can also be found (see attachment) The author of Cncrypt has not had time to update the software, but the official domain is still his. Cncrypt.zip

Well,... https://www.virustotal.com/gui/file/64d293467343a6f83f023b6fbe30e7ac812f45c5981865a3587e15967b5e5427/detection

fzxx commented 1 year ago

@idrassi @wendig0x @alt3r-3go 另一个分支的真密,Cncrypt,其中有许多功能,还可以发现(见附件)提交人的Cncrypt已经没有时间来更新软件,但官方领域仍然是他的。 Cncrypt.zip

好吧,... https://www.virustotal.com/gui/file/64d293467343a6f83f023b6fbe30e7ac812f45c5981865a3587e15967b5e5427/detection

Cncrypt uses UPX compression (Veracrypt does not), it is normal to be misreported, if you are worried about viruses, please use a virtual machine to run the test.

JustMyGithub commented 1 year ago

Cncrypt uses UPX compression (Veracrypt does not), it is normal to be misreported, if you are worried about viruses, please use a virtual machine to run the test.

If upx is the only issue, you can simply remove the upx compression (https://upx.github.io/) and check the unpacked file on VirusTotal. Malware can easily detect common Hypervisors (VMWARE, Hyper-V, VirtualBox...) and just do nothing if executed within one of those.

fzxx commented 1 year ago

Cncrypt uses UPX compression (Veracrypt does not), it is normal to be misreported, if you are worried about viruses, please use a virtual machine to run the test.

If upx is the only issue, you can simply remove the upx compression (https://upx.github.io/) and check the unpacked file on VirusTotal. Malware can easily detect common Hypervisors (VMWARE, Hyper-V, VirtualBox...) and just do nothing if executed within one of those.

if everyone simply used UPX, there would be no encryption shell; unpacking and then scanning is safe (it exists digitally signed) and virustotal's scan cannot be used as a reference. Actual analysis of software behavior is required and will not be discussed here. https://www.virustotal.com/gui/file/504c93580edc53ef1c47d71e033ec8f278811179cbf9b2cdda88408c551f17de