Add Your Reaction Here

[chibicode]

Reactions on this comment will be reflected on https://reactions-demo.vercel.app/

This uses Next.js’s Incremental Static Regeneration feature which is supported out of the box by Vercel’s Edge Network.

[chibicode]

Data Fetching Code:

https://github.com/chibicode/reactions/blob/42e08310fdbdd370a366bc6cacd043e2636c10c6/pages/index.js#L3-L60

[martinseanhunt]

This is so cool!

[anteeek]

Damn.

[Nases]

Exactly what I needed, thanks!

[amir-gorji]

Are you sure its revalidation is done every 1 second or the Github gets updated values after a delay? I get the updated values on the page after a couple of minutes.

[pungggi]

Interstingly it updated the first time after a second and a second time after some minutes..

[msreekm]

page is not refreshing after1 sec! updated only after few mins..

[nghiepnguyen520]

page is not refreshing after1 sec! updated only after few mins..

yes, I tested and same issue with you

[mdovn]

So the first request that trigger the incremental build will alway get the stale data?

[thisisbintang]

It's fast and absolutely static.

[Abdalhadi-Jarad]

Is it expected to be updated alone every 1 second without refreshing ? Because I wait 20 Minutes just watching if it will update the information and still not updating

[cobrexus]

@Abdalhadi-Jarad no, since it's a static page you have a refresh a couple of times to regenerate the page.

[jrayo]

Just in case anyone wants to know how this demo behaves with different timeouts, I made a fork and you can see it on https://reactions.jrayo.vercel.app/

[zhangfaliang]

Is it expected to be updated alone every 1 second without refreshing ? Because I wait 20 Minutes just watching if it will update the information and still not updating

[cobrexus]

@zhangfaliang no, since it's a static page you have a refresh a couple of times to regenerate the page.

[coderinblack08]

this has got to be a record :D

[Slipromise]

hello github

[javakian]

hello, hello, yes i think so

[zed-b]

Great, but I am a little bit confused, doesn't this feature just beg for custom bots to poll the static sites periodically, since the first page served after timeout is stale?

[cobrexus]

Great, but I am a little bit confused, doesn't this feature just beg for custom bots to poll the static sites periodically, since the first page served after timeout is stale?

@zed-b the page served whilst the timeout is stale displayed a loading or skeleton or blank page whilst the new page is being regenerated.

[mkotsollaris]

@chibicode @leerob I think I am missing something. I modified the code (see gist) to print out a given timestamp passed through getStaticProps. I would expect that the page should regenerate every minute, and hence my timestamp shouldn't change during refresh. However, I noticed that when I refresh the page, the timestamp is always updated. thoughts? 🤔

Update: I just realized that during yarn dev getStaticPropstriggers all the time during refresh, but when running fromyarn start`, getStaticProps behaves as it should!

[GBR-422777]

[JoshuaR503]

Does anybody know why my reactions are not up to date? I visited the demo app a while ago and it worked. Yesterday I visited it again and noticed the values have not changed since then.

[Levent0z]

Still not fixed.

[leerob]

Our GitHub personal access token expired. We'll get a new one added. In the meantime, you can see a similar demo here: https://on-demand-isr.vercel.app/

[relaxedleaf]

Hi, do we have updates on renewing the GitHub personal access token?

[mnm1984]

hi

[htrigoso]

raa

[pauloalmeida19]

sdasdasdasdasdsada

[Peter-developer01]

Why it is still not working?

[o-az]

RIP

[aleczratiu]

Ok, the

Our GitHub personal access token expired. We'll get a new one added. In the meantime, you can see a similar demo here: https://on-demand-isr.vercel.app/

Seems that the star number increased, this one is working thanks

[sabeerbikba]

Does anybody know why my reactions are not up to date? I visited the demo app a while ago and it worked. Yesterday I visited it again and noticed the values have not changed since then.

Looks like api cached

[leerob]

FYI: We have an up-to-date demo here https://on-demand-isr.vercel.app/

[ismailarilik]

This is #1 and the most upvoted issue in GitHub. Come on, it shouldn't be that hard to renew a token. Give me the access and I will do whatever necessary without taking one cent.

[ismailarilik]

Just in case anyone wants to know how this demo behaves with different timeouts, I made a fork and you can see it on https://reactions.jrayo.vercel.app/

It seems that this is working as expected but somehow GitHub doesn't send the latest data or this page is not displaying the correct data. UI shows 3492 right now but API returns 3488. But never mind, it is a GitHub bug and since it is not open source I cannot try to fix it. 😎