search

vercel / turborepo

Build system optimized for JavaScript and TypeScript, written in Rust
https://turbo.build/repo/docs
MIT License
26.1k stars 1.8k forks source link

Throw error when no workspace is found #6882

Closed abdelp closed 7 months ago

abdelp commented 8 months ago

Which project is this feature idea for?

Turborepo

Describe the feature you'd like to request

Hi everyone, The specific scenario, for my case, is for GitHub actions, I have some workflows that run tests for different workspaces, and the problem is when there are some misspelled workspaces the execution silently ignores them and succeeds even though it didn't find any workspaces.

Describe the solution you'd like

If you run:

yarn turbo run test --filter=graphl-api # wrong workspace name

instead of

yarn turbo run test --filter=graphql-api

it should abort the execution maybe with a flag --strict or something like that.

Describe alternatives you've considered

The alternative that I considered is to save the output of the command and check its content to see if it matches: Running test in 0 packages

chris-olszewski commented 8 months ago

Hi, we're currently in the process of deciding how we want to better signal possible typos in filters without adding another flag. Will communicate back on this issue once we come to a decision.