search

vercel / turborepo

Build system optimized for JavaScript and TypeScript, written in Rust
https://turbo.build/repo
MIT License
26.48k stars 1.85k forks source link

chore(release): fix release by avoiding old glibc version #9464

Closed chris-olszewski closed 1 week ago

chris-olszewski commented 1 week ago

Description

https://github.com/vercel/turborepo/pull/9447 bumped us to upload-artifact to v4 which uses Node 20. Node 20 required a newer glibc version than was available on our build that targeted AWS's Lambda2's glibc version. See this job for an example failure.

Requiring this glibc version isn't necessary for the musl builds since it uses musl instead of glibc for libc.

I do not think this was intentional to have the musl binary building in this container as we changed this back when we were cross compiling: https://github.com/vercel/turborepo/commit/8ca67c3c0cd9601909730953b9d03699a01b1da8

Future work: This does not fix the @turbo/repository release.

Testing Instructions

Ran test release and x86 msul build now passes: job

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:53pm
8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-basic-web** | ⬜️ Ignored ([Inspect](https://vercel.com/vercel/examples-basic-web/8LZESK4xnD4aJ9HXKdcM6cQguMwn)) | | | Nov 19, 2024 5:53pm | | **examples-designsystem-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/vercel/examples-designsystem-docs/Dti1xaf4MNBup9wcSNL2FG5FFowt)) | | | Nov 19, 2024 5:53pm | | **examples-gatsby-web** | ⬜️ Ignored ([Inspect](https://vercel.com/vercel/examples-gatsby-web/HdRm7hoKohTihxXDDPUpYCrhLF9g)) | | | Nov 19, 2024 5:53pm | | **examples-kitchensink-blog** | ⬜️ Ignored ([Inspect](https://vercel.com/vercel/examples-kitchensink-blog/BQMV24tCFgUFEPWM93fJJzYXvUx8)) | | | Nov 19, 2024 5:53pm | | **examples-native-web** | ⬜️ Ignored ([Inspect](https://vercel.com/vercel/examples-native-web/83JDGG7Lgq2SKPKHnAjjHM5SHPL9)) | | | Nov 19, 2024 5:53pm | | **examples-svelte-web** | ⬜️ Ignored ([Inspect](https://vercel.com/vercel/examples-svelte-web/BSuKUd8SkppKPukiXL73nc3tjYGk)) | | | Nov 19, 2024 5:53pm | | **examples-tailwind-web** | ⬜️ Ignored ([Inspect](https://vercel.com/vercel/examples-tailwind-web/FURqM4NBGgwMpbXsCf5XWw3hJwyC)) | | | Nov 19, 2024 5:53pm | | **examples-vite-web** | ⬜️ Ignored ([Inspect](https://vercel.com/vercel/examples-vite-web/4WGQs3jB7YhUcocAKQv2vawEdWBJ)) | | | Nov 19, 2024 5:53pm |