vericast / conda-mirror

Mirror upstream conda channels
BSD 3-Clause "New" or "Revised" License
71 stars 59 forks source link

conda_mirror.py: added command line swith: --no-validate-target #72

Closed magnuhho closed 6 years ago

magnuhho commented 6 years ago

By default conda-mirror will validate every file that is found within the target folder. This process may take hours. The files are also validated on download, so unless there is file system damage, files in the target folder should be okay.

This change gives an optional command-line argument giving the user the ability to bypass the target folder validation, speeding up the process.

This significantly reduces runtime for initial sync where you may have to run conda-mirror several times before all data is downloaded, depending on speed and stability of your network connection.

codecov-io commented 6 years ago

Codecov Report

Merging #72 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   96.88%   96.89%   +0.01%     
==========================================
  Files           2        2              
  Lines         257      258       +1     
==========================================
+ Hits          249      250       +1     
  Misses          8        8
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 96.86% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f92926...89c17aa. Read the comment docs.

parente commented 6 years ago

LGTM. Thanks! 🍰