Closed magnuhho closed 5 years ago
Merging #74 into master will decrease coverage by
1.77%
. The diff coverage is80%
.
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 93.89% 92.11% -1.78%
==========================================
Files 2 2
Lines 262 279 +17
==========================================
+ Hits 246 257 +11
- Misses 16 22 +6
Impacted Files | Coverage Δ | |
---|---|---|
conda_mirror/conda_mirror.py | 92.02% <80%> (-1.8%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 96bad91...1b6e1b6. Read the comment docs.
Seems like the PR was a bit premature - the arguments that have default values set to something that does not evaluate to False are not overridden by values in the config file. Like temp_directory. I'll look into it
After some interesting merges and some fixup, the change/pr should be good to go now.
Change of plans: I'll merge this and fix the two style nits in the release PR.
… while keeping ability to override from command line.
With this change config.yaml can contain most command line parameters and you can have a config file like
If parameters are both found in the config file and in the given command line arguments, the latter will take precedence.
Now you can simply call conda-mirror with --config