search

verivital / hyst

HyST: A Source Transformation and Translation Tool for Hybrid Automaton Models
http://verivital.com/hyst/
Other
15 stars 18 forks source link

added network implementation for NoSp stateflow converter #4

Closed LuanVietNguyen closed 8 years ago

ttj commented 8 years ago

also deleted old unused files from slsf converter

stanleybak commented 8 years ago

Looks good to me (in the future we can wait a few hours or a day or two for comments before merging, but this one is fine).

One question I have is that I'm not sure if the testing done is just the model file being added, or if matlab has any automated tests that are run like regression tests?

Another is that since the morbido stat model was added to the examples, we should probably test it with the other tools to make sure it doesn't break anything (not sure if this was done or not). We could set up the regression tests to run everything in the examples directory. What do you think Taylor?

I'd also prefer to have a README or something explaining what the morbido stat model is / what paper it came from in case we cite it in the future (not sure if this is a comment in the spaceex model or not).

ttj commented 8 years ago

I don't think we've gotten to automated Matlab tests yet, but is definitely something we're trying to get added soon.

http://www.taylortjohnson.com/

On Fri, Sep 25, 2015 at 4:09 PM, Stanley Bak notifications@github.com wrote:

Looks good to me (in the future we can wait a few hours or a day or two for comments before merging, but this one is fine).

One question I have is that I'm not sure if the testing done is just the model file being added, or if matlab has any automated tests that are run like regression tests?

— Reply to this email directly or view it on GitHub https://github.com/verivital/hyst/pull/4#issuecomment-143355445.