search

verivital / hyst

HyST: A Source Transformation and Translation Tool for Hybrid Automaton Models
http://verivital.com/hyst/
Other
15 stars 18 forks source link

Feature sim hybridization #7

Closed stanleybak closed 9 years ago

stanleybak commented 9 years ago

These are the changes for simulation-based hybridization (mixed-triggered). This adds a transformation pass which performs mixed-triggered hybridization, as well as several junit tests that it's working correctly.

Taylor, I'll give you a few days to review any changes in case you have concerns before I accept and merge.

ttj commented 9 years ago

Overall it looks good. One question though. I didn't see a java file for:

com.verivital.hyst.passes.complex.hybridize.HybridizeMixedTriggeredPass

Where is this located / was it committed and I just missed it?

Additionally, one concern I had before was regarding pass names, I think it should be made consistent. This came up as I didn't see the corresponding file. Some passes require -pass_x and some are just -x. Can we standardize? I would prefer the prefix pass as it makes it clear it's a transformation.

stanleybak commented 9 years ago

Arg, the .java file for the pass was missing. I'll issue another pull request in a second.