magithub-cache no doesn't default to offline mode

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub

GNU General Public License v3.0

579 stars 63 forks source link

magithub-cache no doesn't default to offline mode #291

Closed rgrinberg closed 6 years ago

rgrinberg commented 6 years ago

The documentation states that (setq magithub-cache t) should make magithub start in cached mode. But this doesn't seem to be the case when I try it. I still get that delay when doing magit-status on various repos.

vermiculus commented 6 years ago

Bah, that documentation is outdated, then. This is now controlled by the git variable magithub.cache.

vermiculus commented 6 years ago

Fixed in 8d8d136ae4c380f004354675519f4016c735d78c. Thanks for the report!

rgrinberg commented 6 years ago

Awesome! I'm grateful for all the support for us offline mode users. I know you've been hearing quite a lot of complaints about this stuff with regards to just this one feature. Keep up the good work.

vermiculus commented 6 years ago

There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.

It's true 😄