magit-popup-set-variable was removed

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub

GNU General Public License v3.0

579 stars 63 forks source link

magit-popup-set-variable was removed #307

Closed tarsius closed 6 years ago

tarsius commented 6 years ago

Magit-Popup 2.12.3 removes magit-popup-set-variable and some other functions again. They were already removed in 2.12.1 but had to be restored in 2.12.2 due to packaging issues.

Magithub is using that function and you will have to move it there or use the replacement that are now defined in Magit.

https://github.com/magit/magit-popup/commit/4c030aca025bcb7a39d43b0db758990963ca3b91
https://github.com/magit/magit/commit/e95550cd40d866adc1b38c8d94c9504ffe6ac652

vermiculus commented 6 years ago

Thanks for letting me know! I'll be in the Netherlands for a week on business so I may not be able to do much, but I'm hoping at least to release a stable version of this package now that 2.12 is out. It's up in the air what I'll be in any condition to do mentally, though; working with a six hour time difference.

vermiculus commented 6 years ago

Related magit/magit#3274