search

vert-x3 / vertx-jdbc-client

JDBC support for Vert.x
Apache License 2.0
126 stars 90 forks source link

Make tests runnable on M1 Macs #288

Closed mnylen closed 2 years ago

mnylen commented 2 years ago

Motivation:

The test containers version is not compatible with M1 Macs. This upgrades the test containers to a more recent version with proper aarch64 support.

Also, the yandex/clickhouse-server image is not compatible with aarch64. Afaik, the yandex/clickhouse-server is anyway deprecated, so changed the tests to use clickhouse/clickhouse-server that has aarch64 support in newer tags.

After these, it's possible to run most of the test suite (except Oracle and MSSQL cases) on M1 Macs. Tested with 16" M1 Max MBP.

There was one test (testConnectionReturnedToPoolOnFailingQueryExecutionWhenUsingWithConnection) that seemed to be flaky. More often than not locally it seemed to deadlock waiting for the second connection. I fixed the test by moving the second withConnection to happen after the first connection had been released. But I'm not sure if this is potentially a bug in the implementation that should be investigated more, or if it was only a bug in the test.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

vietj commented 2 years ago

It seems to fail still in CI for ClickHouseOldAPITest