search

vert-x3 / vertx-rx

Reactive Extensions for Vert.x
Apache License 2.0
147 stars 72 forks source link

Use DelegatingHandler for Handler params #283

Closed tsegismont closed 2 years ago

tsegismont commented 2 years ago

Fixes #282

DelegatingHandler overrides hashCode/equals by invoking the delegate corresponding methods. This fixes issues that we have when a handler can be added or removed from sets or lists.

tsegismont commented 2 years ago

Not sure what's wrong yet, the build passes on my box

tsegismont commented 2 years ago

Not sure what's wrong yet, the build passes on my box

I got it, it's because the build of vert.x core hasn't passed after https://github.com/eclipse-vertx/vert.x/pull/4423 has been merged (due to unrelated errors). Once we get a new snapshot of vert.x core, the problem with this build should go away

tsegismont commented 2 years ago

Not sure what's wrong yet, the build passes on my box

I got it, it's because the build of vert.x core hasn't passed after eclipse-vertx/vert.x#4423 has been merged (due to unrelated errors). Once we get a new snapshot of vert.x core, the problem with this build should go away

The build has passed @vietj @cescoffier @jponge

tsegismont commented 2 years ago

@vietj any comment on this one?