search

vert-x3 / vertx-service-discovery

Some tools one can use for doing microservices with Vert.x
Apache License 2.0
114 stars 67 forks source link

Expose ServiceDiscoveryOptions used on started ServiceDiscovery instances #34

Closed aschrijver closed 8 years ago

aschrijver commented 8 years ago

Consuming and announce and usage events is straightforward when service discovery creation and registration occur in the same object, but when passing the discovery instance around to other objects there is no way to determine on which addresses it is broadcasting events, because the used ServiceDiscoveryOptions is not exposed on the discovery instance.

True, you can externalize the addresses to known values, but this becomes unwieldy when having multiple service discovery instances. Therefore I would like to have the deployed options exposed on the service discovery instance.

cescoffier commented 8 years ago

👍

It would be a nice improvement. Fancy a PR ?

cescoffier commented 8 years ago

I was on this project, so did it.

aschrijver commented 8 years ago

Thanks! I didn't see your pull request request. Sorry :) I am about to release an extension of the service discovery with a new graphql-service type (maybe tomorrow or the day after). The project will be here: https://github.com/engagingspaces/vertx-graphql-service-discovery

cescoffier commented 8 years ago

Can't wait, it looks pretty cool!

aschrijver commented 8 years ago

Well, the code is there now. Still have to create some README lines, and more fun like that :)

Oh, BTW, I have two @Ignored unit tests that I couldn't figure out. If you can spare a minute maybe the issue there. I am quite sure the code is okay, but the test is not (wrong use of Vert.x unit maybe).