search

vert-x3 / vertx-service-proxy

EventBus Proxy generation
Apache License 2.0
66 stars 58 forks source link

Prune ServiceProxyProcessor #110

Closed slinkydeveloper closed 3 years ago

slinkydeveloper commented 4 years ago

Because now the annotation processor entrypoint is always "CodegenProcessor from vertx-codegen, we don't need this class anymore. https://github.com/vert-x3/vertx-service-proxy/blob/master/src/main/java/io/vertx/serviceproxy/generator/ServiceProxyProcessor.java#L25

slinkydeveloper commented 4 years ago

@vietj Can we remove it for 4.0?

vietj commented 3 years ago

@slinkydeveloper can you elaborate why it needs to be removed ?

slinkydeveloper commented 3 years ago

comment updated

vietj commented 3 years ago

I set deprecate because there cannot be a migration path from Vert.x 3 to Vert.x 4 if we remove the processor.

slinkydeveloper commented 3 years ago

It's already deprecated, this issue is meant to remind us we need to prune it :smile:

vietj commented 3 years ago

is it deprecated in 3.X ?

slinkydeveloper commented 3 years ago

Yes: https://github.com/vert-x3/vertx-service-proxy/blob/3.9/src/main/java/io/vertx/serviceproxy/generator/ServiceProxyProcessor.java#L25

vietj commented 3 years ago

alright then, I think what we need is update the 4.0.0 wiki page and have a step in the 4.0 migration guide

slinkydeveloper commented 3 years ago

Ok so together with adding a step in the migration guide, can I move forward with removing that class?

vietj commented 3 years ago

yes @slinkydeveloper