search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 531 forks source link

MultipartForm sets TRANSFER-ENCODING chunked #2283

Open DemonicTutor opened 1 year ago

DemonicTutor commented 1 year ago

Version

Vertx 4.3.4

Context

https://netty.io/news/2022/09/08/4-1-81-Final.html

Connection related headers in HTTP/2 frames are now rejected, in compliance with the specification

Reproducer

https://github.com/DemonicTutor/vertx-434-issues https://github.com/DemonicTutor/vertx-434-issues/blob/main/src/test/java/com/noenv/vertx434issues/MultipartFormTest.java

Steps to reproduce

  1. WebClient.sendMultipartForm

Extra

pmlopes commented 1 year ago

@DemonicTutor mutipart form is handled by vertx-core as it delegates to netty to do the parsing

DemonicTutor commented 1 year ago

im talking about the client part... WebClient ueses https://github.com/vert-x3/vertx-web/blob/master/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/MultipartFormUpload.java#L69-L72

and the DefaultFullHttpRequest Http_1_1 sets the header

yeah VertX is using Netty but specifically Http 1 implementation