Previously, we've been testing with 4242 4242 4242 4242 using the vgs collect version 2.15.0 and the validations in place in line with your documentation:
validations={['required', 'validCardNumber']}
This stopped the number at 16 chars max length.
Without changing code, and only by upgrading to vgs collect 2.22.0, we are now able to type in 3 extra chars.
If it's a 16-digit card, it should stop at 16 digits.
Sanity checked myself by trying out a Mastercard number that only allows 16 chars per your documentation table.
While it seems like per your documentation the length of 19 is expected for certain Visa cards, to us it's a bug because previously it stopped the 4242... card at 16 without allowing room for more characters to be typed in.
I don't know what happened between 2.15.0 and 2.22.0 to cause this. In the same way that you're able to deduce that the 2222 is a Mastercard number and stops at 16 digits, can the same not be done for certain Visa cards?
Possible Solution
If there isn't a way to determine by the first few numbers that it's a Visa success card, or whether it should be a 16- or 19-digit card, what is the best way to stop 16-digit cards from reaching extra 3 digits?
Steps to Reproduce (for bugs)
Be on VGS Collect version 2.22.0
Use validations validations: ['required', 'validCardNumber'], type: 'card-number
Try standard Visa success test card 4242 4242 4242 4242 then see if you can type extra 424
Context
Your Environment
Version used: VGS 2.22.0 (bugged), 2.15.0 (was working)
Browser Name and version: Chrome Version 124.0.6367.91
Operating System and version (desktop or mobile): MacOS Ventura 13.4
Expected Behavior
Previously, we've been testing with
4242 4242 4242 4242using the vgs collect version2.15.0and the validations in place in line with your documentation:This stopped the number at 16 chars max length. Without changing code, and only by upgrading to vgs collect
2.22.0, we are now able to type in 3 extra chars.If it's a 16-digit card, it should stop at 16 digits.
Current Behavior
I noticed in your test data documentation that the length of 19 is apparently accepted: https://www.verygoodsecurity.com/docs/vgs-collect/test-data
Sanity checked myself by trying out a Mastercard number that only allows 16 chars per your documentation table.
While it seems like per your documentation the length of 19 is expected for certain Visa cards, to us it's a bug because previously it stopped the
4242...card at 16 without allowing room for more characters to be typed in.I don't know what happened between 2.15.0 and 2.22.0 to cause this. In the same way that you're able to deduce that the
2222is a Mastercard number and stops at 16 digits, can the same not be done for certain Visa cards?Possible Solution
If there isn't a way to determine by the first few numbers that it's a Visa success card, or whether it should be a 16- or 19-digit card, what is the best way to stop 16-digit cards from reaching extra 3 digits?
Steps to Reproduce (for bugs)
validations: ['required', 'validCardNumber'],type: 'card-number4242 4242 4242 4242then see if you can type extra424Context
Your Environment