search

veskuh / Tweetian

A feature-rich Twitter app for smartphones developed using Qt/QML
GNU General Public License v3.0
50 stars 26 forks source link

Remorsify follow and unfollow #131

Closed ghost closed 10 years ago

ghost commented 10 years ago

Use RemorsePoopup in UserPage.qml when follow and unfollow move some of that logic to main.qml so user can back navigate without error.

siteshwar commented 10 years ago

Code changes in this pull request looks fine. But while testing this pull request I was not able to cancel my action (something related to #130). With code changes in this pull request I was not even able to open user image by clicking on bottom half part of it.

ghost commented 10 years ago

Did you test this on device or emulator?

I saw this issue in emulator also when remove tweet(using same API:s). But no problem on phone.

siteshwar commented 10 years ago

I tested on emulator with latest version of SDK.

veskuh commented 10 years ago

I saw the same issue as @siteshwar on canceling the popup in emulator. That looks like a platform issue, the code here does not look related.

ghost commented 10 years ago

discussed fixed in latest patches.

veskuh commented 10 years ago

merging, thanks.