search

vesoft-inc / nebula-python

Client API of Nebula Graph in Python
194 stars 78 forks source link

fix connection not release bug #353

Closed ghjhhyuyuy closed 3 months ago

ghjhhyuyuy commented 5 months ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

When authenticate to graphd failed,the status of the connection has not been modified, resulting in the inability to continue using it in the future.I encountered this issue and thinking this commit can fix it.

How do you solve it?

Modify connection status is_used to False

Special notes for your reviewer, ex. impact of this fix, design document, etc:

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.36%. Comparing base (8560e0e) to head (2923348).

Files Patch % Lines
nebula3/gclient/net/Connection.py 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #353 +/- ## ======================================= Coverage 75.36% 75.36% ======================================= Files 19 19 Lines 2724 2724 ======================================= Hits 2053 2053 Misses 671 671 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wey-gu commented 3 months ago

@HarrisChu @Nicole00 kindly check the change now, what do you think?