search

vespene-io / _old_vespene

DISCONTINUED: a frozen fork will exist forever at mpdehaan/vespene
http://vespene.io/
Apache License 2.0
650 stars 66 forks source link

Fedora Support #105

Closed mcodd closed 5 years ago

mcodd commented 5 years ago

Per discussion at https://talk.msphere.io/t/not-seeing-changes-in-master-from-a-couple-merged-prs/132 I also noticed that https://github.com/vespene-io/vespene/pull/98/ had gone missing. This replicates @seaburr's PR for Fedora support there. It doesn't feel right taking implicit credit for it, but I also don't want to see it just go missing!

(this should also still merge just fine after my amazon linux 2 PR at https://github.com/vespene-io/vespene/pull/104 is merged since this is just one more commit on top of that, but I wanted them to be able to be applied separately in case @seaburr might want to re-submit it himself)

seaburr commented 5 years ago

I don't mind this getting merged back in via this PR. I hope to contribute more. :)

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: mcodd
:x: mpdehaan
You have signed the CLA already but the status is still pending? Let us recheck it.

mpdehaan commented 5 years ago

merged back in, sorry about that folks and thanks for noticing @mcodd!