vesta-webtrees-2-custom-modules / vesta_classic_laf

Vesta Classic Look & Feel (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
17 stars 2 forks source link

Error found in Logfile #122

Closed hartenthaler closed 1 year ago

hartenthaler commented 1 year ago

Undefined variable $tree …/modules_v4/vesta_classic_look_and_feel/resources/views/layouts/default.phtml:41 #0 …/modules_v4/vesta_classic_look_and_feel/resources/views/layouts/default.phtml(41): Fisharebest\Webtrees\Webtrees::Fisharebest\Webtrees{closure}() #1 …/app/View.php(183): include('...') #2 …/app/View.php(278): Fisharebest\Webtrees\View->render() #3 …/app/Helpers/functions.php(145): Fisharebest\Webtrees\View::make() #4 …/app/Http/ViewResponseTrait.php(54): view() #5 …/modules_v4/repository_hierarchy/RepositoryHierarchy.php(1268):

ric2016 commented 1 year ago

This apparently occurs when a view is called without a 'tree' variable, via ViewResponseTrait.

The caller is another custom module in this case, who in fact does not set this variable.

This probably should be handled better in webtrees as well. (Vesta code adjusted from there) - I.e. when disabling Vesta, the same error will show up in the logs via the default layout view.

ric2016 commented 1 year ago

Fixed in latest Vesta release 2.1.16.1.3.