vexxhost / magnum-cluster-api

Cluster API driver for OpenStack Magnum
Apache License 2.0
47 stars 22 forks source link

Add support for `docker_volume_{size,type}` #4

Closed mnaser closed 5 months ago

mnaser commented 2 years ago

At the moment, we cannot use this feature due to the fact that CAPO does not support mounting multiple volumes:

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1286

Once that's in place, we can use the following labels to create volumes:

We can use the following functions to determine the volume type (if size is set):

https://github.com/openstack/magnum/blob/16bdedcf2fe6986c995bd415f4e3c70dac914ada/magnum/common/cinder.py#L25-L37

And we can get the sizes from labels/API objects.

mnaser commented 2 years ago

For what it's worth, this isn't that important, since most users will find https://github.com/vexxhost/magnum-cluster-api/issues/5 more important since that gives them BFV instances.