Vorecode problems

[help-maint]

https://github.com/vgstation-coders/vgstation13/pull/9242/files#diff-7c9cb8d60ac1bf86dac54bbc7e473e7cdcc7eb46d4039fba57f199241a59beb1 @Intigracy This PR had a few problems:

• The "digest" var is local, so the whole digestion switch() never fires because it gets reset to 0 every tick.
• As a result, only the first message will fire. This message also has an incorrect text macro, so the message says "/the the monkey".
• More importantly, since digestion never finishes, you will never be able to eat a second mob.
• Also, digestion seems to be coded to only happen while sleeping. Not sure if this is intended, given the fetishy messages.

[d3athrow]

I hate this but the text macro looks fine to me?

[help-maint]

Slashy thing go other way

[d3athrow]

https://github.com/vgstation-coders/vgstation13/blob/e0843fdcd4f2708b9da06c11bed6c626599744d6/code/modules/mob/living/carbon/alien/humanoid/life.dm#L460 It has \The which is correct, where are you seeing /The

[help-maint]

Other one, line 16 of code/modules/mob/living/carbon/human/life/handle_stomach.dm

[d3athrow]

If it was in the other one then why did you link the xeno proc.

[help-maint]

Link goes to handle_stomach.dm On My Machine

[d3athrow]

weird

[Intigracy]

For what it's worth, this was to make swallowing monkeys or voring people as a xeno less dumb.

On Tue, Apr 6, 2021, 12:28 d3athrow @.***> wrote:

weird

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vgstation-coders/vgstation13/issues/29166#issuecomment-814298957, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA63JJAJIRX6PJNJAHVOESDTHNAFNANCNFSM42PEQH2Q .

[Intigracy]

I remember making a pr that fixed this asking other things that got closed, feel free to look it up and reuse.

On Tue, Apr 6, 2021, 12:33 Travis Inti @.***> wrote:

For what it's worth, this was to make swallowing monkeys or voring people as a xeno less dumb.

On Tue, Apr 6, 2021, 12:28 d3athrow @.***> wrote:

weird

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vgstation-coders/vgstation13/issues/29166#issuecomment-814298957, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA63JJAJIRX6PJNJAHVOESDTHNAFNANCNFSM42PEQH2Q .

[drawsstuff]

jesus h christ those are some fetishy descriptions

[Intigracy]

brap

On Wed, Apr 7, 2021, 09:21 drawsstuff @.***> wrote:

jesus h christ those are some fetishy descriptions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vgstation-coders/vgstation13/issues/29166#issuecomment-814955527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA63JJCTYLSCOO3TUX2MGVDTHRS7TANCNFSM42PEQH2Q .

[Intigracy]

• rscadd: "An alien who dies via meat spike will have their stomachs emptied out on the ground."

This so you had a way to rescue people instead of a xeno eating them being "I win"

• rscadd: "Mobs (such as aliens or fatass humans) can now only eat one mob at a time."

So xenos couldn't just spam eat people for "I win"

• tweak: "Mobs eaten by other mobs are digested (unchanged). The person who ate the other mob will recieve 4 notifications over time after the mob as died as to the status of the mob being digested, with the 4th finishing them off."

Trying to give feedback to people (in an admittedly awful way, in hindsight) about how close they are to bring just gone.

• tweak: "Grabbing someone to the point that it says '(now hands)' no longer causes them to drop what they're holding every second or so. This was done so that mobs who are grabbed while holding something can once again chestburst out of the thing that ate them."

As written above, gives you a fighting chance if the xeno is too dumb to disarm you first.

• bugfix: "Holding an arrow key while inside of a mob's stomach no longer causes it to pretty much instantly gib

Self explanatory.

On Wed, Apr 7, 2021, 19:10 calzilla1 @.***> wrote:

For what reason is this in the code

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vgstation-coders/vgstation13/issues/29166#issuecomment-815351711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA63JJA34JI427OBYLKN6FDTHTX73ANCNFSM42PEQH2Q .

[help-maint]

In hindsight I apologize for the ping as it may have been mean-spirited