vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 544 forks source link

Silicate Sprayer Feedback #6405

Closed Kurfursten closed 7 years ago

Kurfursten commented 9 years ago

Just general stuff I've run into

Otherwise, handy.

@PJB3005

PJB3005 commented 9 years ago

Not following naming conventions. Needs to be lowercase.

Since when is there a naming convention for lowercase?

Kurfursten commented 9 years ago

What? It's not a proper noun. I'm pretty sure you yourself have told me to change this before.

For example, go open the YouTool and look at the capitalization

PJB3005 commented 9 years ago

I put \improper on it though.

Kurfursten commented 9 years ago

It's not lower case in the vendor or when examined.

PJB3005 commented 9 years ago

Wait what?

Okay the vendor's obviously making it lowercase.

But I've got no clue as to why examining it turns out as lowercase?

Kurfursten commented 9 years ago

untitled Why are you making a big deal out of this? Just change it to lowercase like every other non-proper noun.

PJB3005 commented 9 years ago

There's a ton of things in SS13 that are capitalised and improper though.

The reason I'm making a deal out of it is because IMO it looks better.

Kurfursten commented 9 years ago

Nah, it's not a proper noun. It sticks out like a sore thumb in the YouTool because its capitalization is wrong - it looks bad. Keep a consistent style.

PJB3005 commented 9 years ago

Okay at this point we need

PJB3005 commented 9 years ago

Okay at this point we need a proper poll or something whether things should be capitalised or not.

Zth-- commented 9 years ago

We don't need a poll. This capitalization is simply wrong. You don't add a capital letter to every noun when you type, then why are you trying to put it ingame?

PJB3005 commented 9 years ago

There's a lot of things in SS13 already that are capitalised, do you want to change them all?

Kurfursten commented 9 years ago

It would be wonderful if someone would - or even if they would just compile a list of such things. But until then, the best we can do is fix the problems where we find them, like here.

FudgePucker commented 9 years ago

The sprayer isn't that big of an issue balance wise. I still think the big problem that is a big suprise it hasn't been abused yet is the fact that there are now silicate tanks in easy to access areas. Silicate has two componints of thermite, all you need is iron and you can burn holes into secure areas.

Shit I think having tanks of sulf. acid for soldering irons would cause less mayhem.

Kurfursten commented 9 years ago

What's the point of having tanks in the first place if you only have to fill up a sprayer once? I've never filled a sprayer except when it was freshly printed.

You could probably safely remove the tanks from every map, since the only time someone will visit a chemist for a refill is when it's made.

FudgePucker commented 9 years ago

@Kurfursten Or have tanks avaliable from cargo, and one in engineering and have the sprayers start filled.

EDIT: Also there is the factor of people who know the power of the silicate tanks and their level of shit. How many players that know silicate contains aluminum and oxygen would do non antag bullshit like melting into every place? I have only really GRAY TIDE WORLD WIDE'd twice, once where I decided 'well if I have to hack into CEs office to open secure storage, might as well hack into the captians office for all access' and then proceded to make 20 all access IDs, the security officer who caught me just looked in my bag and killed himself, and the one time I was playing botanist and became the queen of the green tide when I gave all the new dioana all access IDs, the HoS uploaded a law to the AI to make me non human.

The fact that every wall on the station hasn't been melted down every round should show that this isn't that big of an issue because shitters can't into ghetto chemistry. Because if this was being abused enough then secure armory would be looted every round from space.

Kurfursten commented 9 years ago

It also may not have happened because it's not possible. Ghetto chemistry uses a white list of reactions to prevent this kind of thing. It's kinda badcode though - mostly done because months ago we didn't really know what the implications of ghettochem would be once it was in game. After the FF ends I'll PR a change to use every reaction datum without an explicit whitelist.

FudgePucker commented 9 years ago

Oh wait so you added every chemical by hand to the list of reactions? Wowzers thats some dedication.

I could always make a bug issue about silicate not being able to be used in ghetto chemistry and then you can always fix the bug :^).

Probe1 commented 7 years ago

Everything that was urgent has had its time to be addressed and everything that wasn't I put to you. To either code it or reopen a new issue in 2016 (god nearly 2017).