search

vgteam / vg

tools for working with genome variation graphs
https://biostars.org/tag/vg/
Other
1.12k stars 194 forks source link

Protobuf plural repeated fields ought to be singular #695

Open adamnovak opened 7 years ago

adamnovak commented 7 years ago

In the original protobuf objects (like Graph), repeated fields are singular (node and edge).

In some of the newer messages like Pileup and SnarlTraversal, some repeated fields are plural (node_pileups, base_pileups, visits).

We should change them all to be singular, so we don't say things like snarl.visits_size() and *pileup.add_node_pileups() = one_node_pileup.

@jeizenga @glennhickey @ekg Do you have opinions on this?

jeizenga commented 7 years ago

Sure. Don't really care either way.