BUG: cutadapt base quality cutoff arguments have the wrong type

viash-hub / biobox

🌱📦 A collection of bioinformatics tools for working with sequence data.

https://web.viash-hub.dev/package/biobox

MIT License

4 stars 6 forks source link

BUG: cutadapt base quality cutoff arguments have the wrong type #66

Closed DriesSchaumont closed 5 months ago

DriesSchaumont commented 5 months ago

Description

Issue ticket number

~Closes #xxxx~

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Conforms to the Contributing guidelines
[x] Proposed changes are described in the CHANGELOG.md
[x] I have tested my code with viash ns test --parallel -q <name or namespace>
Check the correct box. Does this PR contain:
- [ ] Breaking changes
- [ ] New functionality
- [ ] Major changes
- [ ] Minor changes
- [ ] Documentation
- [x] Bug fixes

DriesSchaumont commented 5 months ago

Closing, it seems that it is possible to provide multiple values for this argument (e.g. -q "20,30"). Its possible to use multiple: true, but there are problems with providing nullable types for these. See https://github.com/viash-io/viash/issues/705