Separate front and API

[vicb]

Summary by Sourcery

This pull request separates the front-end and API configurations by refactoring API key retrieval and updating fetch requests to use environment-specific URLs. It also introduces a CORS allow list for better security and updates the documentation to reflect these changes.

• Enhancements:
  • Refactored API key retrieval to use environment variables instead of a static keys file.
  • Updated various fetch requests to use environment-specific API server URLs.
  • Introduced a CORS allow list to restrict access to specific domains.
• Documentation:
  • Updated CONTRIBUTING.md to reflect changes in environment variable setup and added a new command for fixing lint errors.
• Chores:
  • Removed unused environment configuration files from the front-end project.

Summary by CodeRabbit

• New Features

  • Introduced environment variable configuration for server endpoints and API keys in local and production environments.
  • Added a new Secrets library for managing sensitive keys and configurations.

• Bug Fixes

  • Updated API endpoint URLs to dynamically fetch from environment variables, ensuring correct server references.

• Refactor

  • Replaced SecretKeys with Secrets across various modules for better key management.
  • Adjusted key and host retrieval methods for robustness.

• Chores

  • Updated .gitignore to exclude private development keys.
  • Adjusted project dependencies to include the secrets project for build and test phases.

[gitguardian[bot]]

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [11668956](https://dashboard.gitguardian.com/workspace/65432/incidents/11668956?occurrence=145983615) | Triggered | Google API Key | f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyxc/commit/f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R17) | | [11668956](https://dashboard.gitguardian.com/workspace/65432/incidents/11668956?occurrence=145983621) | Triggered | Google API Key | f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyxc/commit/f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R16) | | [11668957](https://dashboard.gitguardian.com/workspace/65432/incidents/11668957?occurrence=145983614) | Triggered | Google API Key | f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyxc/commit/f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R14) | | [11668957](https://dashboard.gitguardian.com/workspace/65432/incidents/11668957?occurrence=145983616) | Triggered | Google API Key | f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyxc/commit/f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R11) | | [11668957](https://dashboard.gitguardian.com/workspace/65432/incidents/11668957?occurrence=145983618) | Triggered | Google API Key | f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyxc/commit/f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R12) | | [11668957](https://dashboard.gitguardian.com/workspace/65432/incidents/11668957?occurrence=145983619) | Triggered | Google API Key | f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyxc/commit/f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R10) | | [11668957](https://dashboard.gitguardian.com/workspace/65432/incidents/11668957?occurrence=145983620) | Triggered | Google API Key | f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyxc/commit/f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R13) | | [11668958](https://dashboard.gitguardian.com/workspace/65432/incidents/11668958?occurrence=145983617) | Triggered | Google API Key | f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyxc/commit/f53e3a0d4c1d5b80b25ffa7c32bc7e71aac80329#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R15) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/googleaiza#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[sourcery-ai[bot]]

Reviewer's Guide by Sourcery

This pull request separates the front-end and API configurations by introducing environment variables for API and front-end server URLs. It also refactors the way API keys are managed and updates various fetch calls to use these new environment variables.

File-Level Changes

Files	Changes
apps/fxc-front/src/app/pages/archives.ts apps/fxc-front/src/app/pages/admin.ts apps/fxc-front/src/app/pages/settings.ts apps/fxc-front/src/app/logic/track.ts apps/fxc-front/src/app/components/ui/waypoint-modal.ts apps/fxc-front/src/app/redux/track-slice.ts apps/fxc-front/src/app/components/ui/google-btn.ts apps/fxc-front/src/app/components/2d/map-element.ts apps/fxc-front/src/app/components/3d/map3d-element.ts apps/fxc-front/src/app/components/ui/main-menu.ts apps/fxc-front/src/app/components/ui/supporter-modal.ts apps/fxc-front/src/app/redux/live-track-slice.ts	Updated fetch calls and form action URLs to use environment variables for API and front server URLs.
apps/fxc-server/src/main.ts apps/fxc-server/src/environments/environment.prod.ts apps/fxc-server/src/environments/environment.ts	Introduced new environment variables for OAuth origin, cookie domain, cookie name, and CORS allow list. Added CORS middleware.
apps/fxc-front/src/app/apikey.ts apps/fxc-front/src/env.d.ts	Refactored API key management to use environment variables and updated type definitions.
apps/fxc-server/project.json	Removed dist/apps/fxc-front from assets.
CONTRIBUTING.md	Updated instructions for setting up environment variables.
apps/fxc-front/src/flyxc.ts	Reorganized imports.
apps/fxc-front/src/environments/environment.ts apps/fxc-front/src/environments/environment.prod.ts	Deleted environment files.

---

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

[coderabbitai[bot]]

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

The recent changes focus on refining environment configurations, enhancing API key handling, and updating various paths and dependencies. Key updates include the introduction of new environment variables, dynamic URL constructions using these variables, and the transition from SecretKeys to Secrets for secure key management. Additionally, there are improvements in linting support and dependency management across multiple projects.

Changes

File(s) or Path(s)	Summary of Changes
CONTRIBUTING.md	Updated file paths, added npm run fixlint command, removed default key definitions setup.
apps/fxc-front/.env.development.local	Introduced new environment configurations for local development.
apps/fxc-front/.env.production	Added new environment variables for API servers and keys for production.
apps/fxc-front/.gitignore	Excluded .env.development from version control.
apps/fxc-front/src/app/apikey.ts	Refactored getApiKeyAndHost function, introduced API_NAME type and MISSING_KEY constant.
apps/fxc-front/src/app/components/...	Updated API key usage and URLs to use environment variables dynamically.
apps/fxc-front/src/env.d.ts	Added new environment variables to ImportMetaEnv interface.
apps/fxc-front/src/flyxc.ts	Moved import statement for liveTrack above planner.
apps/fxc-server/project.json	Added dependencies on secrets project, modified asset list.
apps/fxc-server/src/app/routes/...	Replaced SecretKeys with Secrets for secure key management.
apps/fxc-server/src/environments/environment.ts	Renamed and added new properties for better configuration management.
apps/misc/project.json	Added dependencies on secrets project for build and test phases.
apps/misc/src/app/email_inreach.ts	Replaced SecretKeys with Secrets for secure key management.
apps/proxy/project.json	Added dependencies on secrets project for build and test phases.
apps/proxy/src/main.ts	Replaced SecretKeys with Secrets for secure key management.
apps/run/project.json	Added dependencies on secrets project for build and test phases.
libs/common-node/src/lib/redis.ts	Updated getRedisClient function to accept a url parameter.
libs/common/src/lib/index.ts	Removed export of keys.
libs/secrets/...	Introduced new secrets library configuration and setup.

Poem

In the code where secrets hide,
New paths and keys now reside.
Environment variables take the stage,
Dynamic URLs on every page.
With Secrets safe and sound,
Our code's security is profound.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[cloudflare-workers-and-pages[bot]]

Deploying flyxc with    Cloudflare Pages

Latest commit:	f53e3a0
Status:	✅  Deploy successful!
Preview URL:	https://e3387e97.flyxc.pages.dev
Branch Preview URL:	https://prereq.flyxc.pages.dev

View logs