search

vicb / flyXC

One stop shop web app for paraglider pilots. Plan, visualize, and track your flights.
https://flyxc.app
MIT License
97 stars 34 forks source link

Fix route length in the planner #226

Closed vicb closed 5 months ago

vicb commented 5 months ago

Thanks Brian Black for the report

/cc @flyingtof

Summary by Sourcery

This pull request fixes the route length calculation in the planner by ensuring the distance is measured in meters and speed in km/h. It also includes refactoring for clarity and a minor syntax fix in the admin page.

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

The recent updates primarily involve renaming variables and functions for clarity and consistency, specifically changing speed to speedKmh and distance to distanceM. Additionally, there were adjustments in event handling logic within the AdminPage class to ensure proper function calls. These changes enhance code readability and maintainability.

Changes

Files/Paths Change Summaries
.../components/2d/path-element.ts Renamed setDistance to setDistanceM, imported getPreciseDistance, updated path vertex removal logic, adjusted distance handling.
.../components/2d/planner-element.ts Renamed setSpeed to setSpeedKmh, speed to speedKmh, distance to distanceM, adjusted related calculations.
.../pages/admin.ts Corrected the click event handler for the "Logout" button to call the logout method properly.
.../redux/planner-slice.ts Renamed speed to speedKmh, distance to distanceM, updated corresponding action functions and state updates.
.../flyxc.ts Updated setSpeed function call to setSpeedKmh in store.dispatch.

Poem

In code's vast and winding trail,
Distances in meters, speeds in km/h prevail.
With clicks and paths now set just right,
Our admin logs out without a fight.
Oh, how the code does gleam and glow,
As changes help the project grow!
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sourcery-ai[bot] commented 5 months ago

Reviewer's Guide by Sourcery

This pull request addresses the issue of route length calculation in the planner by renaming variables to more accurately reflect their units and ensuring the distance is calculated in meters. The changes involve updating variable names and logic in multiple files to maintain consistency and correctness.

File-Level Changes

Files Changes
apps/fxc-front/src/app/redux/planner-slice.ts
apps/fxc-front/src/app/components/2d/path-element.ts
apps/fxc-front/src/app/components/2d/planner-element.ts
apps/fxc-front/src/flyxc.ts		 Renamed variables related to speed and distance to include units (Kmh and M) and updated related logic and state handling to ensure consistency and correctness.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying flyxc with  Cloudflare Pages  Cloudflare Pages

Latest commit: c75fa66
Status: ✅  Deploy successful!
Preview URL: https://ccbc8c25.flyxc.pages.dev
Branch Preview URL: https://fix-length.flyxc.pages.dev

View logs