Misc minor changes - Githubissues

vicb commented 4 months ago

Summary by Sourcery

This pull request includes several minor enhancements and chore updates. Key changes involve the removal of Google Analytics and Klaro scripts, updates to ESLint configurations, and the replacement of Klaro with Zaraz for cookie management. Additionally, various ignore patterns and type definitions have been updated.

Enhancements:
- Removed Google Analytics and Klaro privacy manager scripts from the index.html file.
- Updated ESLint configuration to exclude test files and enforce no extraneous dependencies in the libs/optimizer/.eslintrc.json file.
- Modified the Google Maps API loading function to remove Google Analytics event tracking in the map-element.ts file.
- Replaced Klaro with Zaraz for handling cookie settings in the about-modal.ts file.
- Added Zaraz type definition to the global scope in the env.d.ts file.
Chores:
- Updated ignore patterns in various .eslintrc.json files to include .vite, .cache, and node_modules directories.
- Fixed a minor regex formatting issue in the pwa.config.ts file.
- Removed redundant type reference for gtag.js in the tsconfig.json file.

Summary by CodeRabbit

New Features
- Added zaraz consent management to replace Klaro.
Improvements
- Enhanced ESLint configurations to ignore additional directories.
- Updated .gitignore to exclude specific development files.
- Refactored PWA configuration for better pattern matching.
Removals
- Removed Klaro consent management and Google Analytics scripts from index.html.
- Removed all references to Google Analytics (gtag.js).
Bug Fixes
- Fixed import order in service worker file for better caching strategy.
Documentation
- Updated type declarations to include zaraz and its showConsentModal property.

coderabbitai[bot] commented 4 months ago

Walkthrough

The overall changes focus on updating ESLint configurations, enhancing gitignore rules, and refining project files for a better development experience. Notably, Google Analytics and Klaro consent management functionalities have been removed, replaced by Zaraz consent modal. Additionally, unnecessary dependencies and imports have been cleaned up, leading to a more streamlined and efficient codebase.

Changes

File path	Summary
.eslintrc.json	Updated ignore patterns to exclude .vite/, .cache/, node_modules/, and other directories.
.gitignore	Added apps/fxc-front/dev-dist/registerSW.js to the ignore list.
apps/fxc-front/.eslintrc.json	Updated ignore patterns to exclude .vite, node_modules, and .cache directories.
apps/fxc-front/index.html	Removed script tags for Klaro consent management and Google Analytics setup.
apps/fxc-front/pwa.config.ts	Adjusted regex pattern in dontCacheBustURLsMatching to remove escape character.
apps/fxc-front/src/.../map-element.ts	Modified loadGMaps to exclude host parameter and removed gtag event tracking.
apps/fxc-front/src/.../ui/about-modal.ts	Replaced Klaro consent modal call with Zaraz consent modal.
apps/fxc-front/src/env.d.ts	Removed @types/gtag.js and added declaration for Zaraz with showConsentModal property.
apps/fxc-front/src/sw.ts	Reordered imports to place googleFontsCache above other workbox imports.
apps/fxc-front/tsconfig.json	Removed @types/gtag.js from types array.
libs/optimizer/.eslintrc.json	Excluded *.spec.ts files from import/no-extraneous-dependencies rule.
package.json	Removed @types/gtag.js package from dependencies.

Poem

Amid the code, a change so bright,
ESLint patterns to fortify the night,
No more Klaro, Zaraz takes the stage,
Cleaned up paths, a developer's wage.
With every tweak, our spirits lift,
In code's embrace, we find our thrift.
🌟✨🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request includes miscellaneous minor changes across several files. The most significant changes involve the removal of Google Analytics and Klaro scripts and references, as well as updates to ESLint configurations to exclude certain files and add new rules. Additionally, there are minor fixes and updates to regex patterns and import statements.

File-Level Changes

Files	Changes
`apps/fxc-front/index.html` `apps/fxc-front/src/app/components/2d/map-element.ts` `apps/fxc-front/src/env.d.ts` `apps/fxc-front/tsconfig.json`	Removed Google Analytics and Klaro scripts and references.
`.eslintrc.json` `libs/optimizer/.eslintrc.json` `apps/fxc-front/.eslintrc.json`	Updated ESLint configurations to exclude certain files and add new rules.

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying flyxc with Cloudflare Pages

Latest commit:	`42a5aba`
Status:	✅ Deploy successful!
Preview URL:	https://4942a6df.flyxc.pages.dev
Branch Preview URL:	https://misc.flyxc.pages.dev

View logs

vicb / flyXC

Misc minor changes #244