search

vicb / flyXC

One stop shop web app for paraglider pilots. Plan, visualize, and track your flights.
https://flyxc.app
MIT License
97 stars 34 forks source link

Fix windy-sounding build #253

Closed vicb closed 5 months ago

vicb commented 5 months ago

Summary by Sourcery

This pull request addresses a bug in the windy-sounding project configuration by removing the verbose flag from the production build command. Additionally, it updates the GitHub Actions workflow to include an npm install command for the libs/windy-sounding directory.

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

[!WARNING]

Rate limit exceeded

@vicb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 47 minutes and 34 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between c2cdfc0d1df899ea747a3b09e7236eb0d42df643 and d281f5a79bf4e5f4644285e62309612a8f077beb.

Walkthrough

The changes introduce several updates across various files to improve the functionality and documentation of the Windy-sounding plugin, which is now renamed to the FlyXC soundings plugin. Key changes include updating GitHub workflows, revising documentation, modifying build configurations, and updating dependencies. These updates aim to streamline the development process, enhance readability, and ensure the plugin is well-maintained and functional.

Changes

Files/Paths Change Summary
.github/workflows/upload-windy-sounding.yml Renamed workflow, added npm install command for a specific directory.
README.md Updated URL to point to the correct location within the GitHub repository.
libs/.../project.json Removed --verbose flag from build command, added development build configuration.
libs/.../CONTRIBUTING.md Updated commands and instructions for running and reloading the plugin on windy.com/dev.
libs/.../README.md Renamed plugin functionality from windy-plugin-sounding to flyXC soundings.
libs/.../generate-manifest.js Updated import statement to use pluginConfig from config.js instead of plugin.min.js.
libs/.../package.json Added and updated various dependencies including @sveltejs/vite-plugin-svelte, preact, etc.
libs/.../vite.config.ts Changed fs allow path and updated lib configuration logic based on BUILD_PLUGIN_CONFIG.

Poem

In the world of code so bright,
A bunny hops with pure delight,
Updates flowing, dependencies rise,
Plugins renamed, taking skies.
With each commit, the future's clear,
FlyXC soundings, we hold dear.
🐇✨🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sourcery-ai[bot] commented 5 months ago

Reviewer's Guide by Sourcery

This pull request focuses on refining the build process for the windy-sounding library. The --verbose flag was removed from the production build command in the project.json file to reduce log noise. Additionally, a step was added in the GitHub Actions workflow to install npm dependencies specifically for the windy-sounding library, ensuring that all necessary packages are available during the build process.

File-Level Changes

Files Changes
libs/windy-sounding/project.json
.github/workflows/upload-windy-sounding.yml		 Improved the build process for the windy-sounding library by removing unnecessary verbosity and ensuring dependencies are installed correctly.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.