search

vicb / flyXC

One stop shop web app for paraglider pilots. Plan, visualize, and track your flights.
https://flyxc.app
MIT License
97 stars 34 forks source link

Fix service worker #256

Closed vicb closed 5 months ago

vicb commented 5 months ago

Summary by Sourcery

This pull request addresses issues with the service worker by fixing its registration and update logic. Additionally, it enhances the handling of the 'beforeinstallprompt' event to prevent unwanted event propagation.

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the flyXC web app by adjusting event handling during the installation prompt and moving service worker registration to the global scope for better reliability. Additionally, the service worker logic has been updated to include a new route, ensuring comprehensive coverage. These modifications refine user interactions and optimize background processes without altering public APIs.

Changes

File Change Summary
apps/fxc-front/index.html Added stopPropagation() and stopImmediatePropagation() to beforeinstallprompt event handling.
apps/fxc-front/src/flyxc.ts Moved registerSW call to global scope; added updateServiceWorker function.
...front/src/sw.ts Updated isIndexRoute function to include /3d path.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Browser
    participant ServiceWorker
    participant App

    User->>Browser: Navigates to site
    Browser->>App: Loads index.html
    App->>Browser: Handles beforeinstallprompt
    Browser-->>App: Event triggered
    Note over App: Stops propagation<br/> Predefaults action
    User->>Browser: Route includes /3d
    Browser->>ServiceWorker: Checks isIndexRoute
    ServiceWorker-->>Browser: Response includes /3d
    Browser->>App: Registers service worker (global scope)
    App-->>ServiceWorker: Calls registerSW globally
    ServiceWorker-->>App: SW registered and updated

Poem

Amidst the code, where changes bloom,
Our FlyXC thrives, dispelling gloom.
In global scope, the workers cheer,
While prompts are tamed, so smooth and clear.
With routes anew, we soar and glide,
In digital skies, we take our ride.
Oh, the joy in updates' stride! 🚀✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sourcery-ai[bot] commented 5 months ago

Reviewer's Guide by Sourcery

This pull request addresses issues with the service worker registration and improves the handling of the beforeinstallprompt event. The changes include adding additional event propagation control in the index.html file, refactoring the service worker registration logic in flyxc.ts, and updating the list of index routes in sw.ts.

File-Level Changes

Files Changes
apps/fxc-front/index.html
apps/fxc-front/src/flyxc.ts		 Refactored service worker registration and improved event handling for the beforeinstallprompt event.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying flyxc with  Cloudflare Pages  Cloudflare Pages

Latest commit: c63f0dd
Status: âœ…  Deploy successful!
Preview URL: https://5104da19.flyxc.pages.dev
Branch Preview URL: https://sw-fix.flyxc.pages.dev

View logs