Sounding pluging improvements

vicb commented 4 months ago

Summary by Sourcery

This pull request includes several bug fixes and enhancements for the Windy Sounding plugin. Key changes include fixing elevation steps, improving cursor handling, and enhancing the Favorites component. Additionally, a new deployment script has been added for publishing the plugin, and the ESLint configuration has been updated.

Bug Fixes:
- Fixed elevation steps in feet (3000ft).
- Cursor values now change based on the cursor position.
- Cursor is no longer removed on mobile devices.
- Coordinates are displayed for unknown places.
- A message is shown when there are no favorites on mobile.
Enhancements:
- Improved cursor handling by adjusting its position and class based on its location on the screen.
- Refined the display of altitude axis by removing redundant format function.
- Enhanced the Favorites component to display coordinates and handle empty favorites list.
Deployment:
- Added a new script (upload.sh) for creating and publishing the plugin archive to Windy API.
Chores:
- Updated ESLint configuration to ignore node_modules directory.

Summary by CodeRabbit

New Features
- Added support for WINDY_API_KEY in the environment configuration.
- Introduced a script to upload the Windy plugin directly to GitHub.
Enhancements
- Improved mobile user experience with better cursor behavior and displaying coordinates for unknown places.
- Enhanced visibility for empty favorites in the Favorites component.
- Adjusted scaling and cursor functions for better performance and precision in the SkewT and WindProfile components.
Bug Fixes
- Fixed elevation steps and altitude axis labels rendering in SkewT component.
Documentation
- Updated CHANGELOG.md with recent changes and fixes for version 4.0.0-alpha.2.
Style
- Added new CSS rule for text alignment in the .bottom class for better UI consistency.
Chores
- Added @nx/webpack version 19.4.1 as a new dependency.
- Updated .gitignore to exclude .env.local.

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request focuses on improving the sounding plugin by enhancing cursor handling, adding new utility functions, and updating event handlers for better user interaction. Significant changes include the introduction of new scales for elevation steps, improved cursor positioning, and the addition of a script for uploading the plugin to the Windy API.

File-Level Changes

Files	Changes
`libs/windy-sounding/src/components/skewt.tsx` `libs/windy-sounding/src/components/wind-profile.tsx`	Improved cursor handling by updating cursor class and yOffsetCursor based on yPointer position.
`libs/windy-sounding/src/containers/containers.tsx` `libs/windy-sounding/src/components/favorites.tsx`	Enhanced user interaction by adding moveCursor function and displaying rounded coordinates for current location.

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate limit exceeded

@vicb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 36 seconds before requesting another review.

How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

Commits
Files that changed from the base of the PR and between fa1d9cc61df8e9da79387960585a32eba356a198 and e0a5bd3a777391aa3de982a5ec5694fb654ad1db.

Walkthrough

The recent updates encompass various modifications and enhancements across multiple files. Key changes include the enhancement of ESLint configuration, adding a new dependency, updating environment variables, refining components' rendering logic, and introducing new user-driven interactions such as cursor behavior adjustments. Significant improvements address mobile user experience, scale calculations, and the introduction of a process to archive and upload plugins to Windy.

Changes

File/Directory	Change Summary
`libs/secrets/.eslintrc.json`	Added `"node_modules/*"` to `ignorePatterns`
`libs/secrets/package.json`	Added new dependency `@nx/webpack` version `19.4.1`
`libs/windy-sounding/.env`	Included `WINDY_API_KEY` environment variable
`libs/windy-sounding/.gitignore`	Added exclusion pattern for the `.env.local` file
`libs/windy-sounding/CHANGELOG.md`	Detailed changes between versions 4.0.0-alpha.2 and 4.0.0-alpha.1
`libs/windy-sounding/src/components/favorites.tsx`	Adjusted favorite location logic, added import of `round`, modified rendering logic
`libs/windy-sounding/src/components/skewt.tsx`	Adjusted scaling functions and cursor position handling
`libs/windy-sounding/src/components/wind-profile.tsx`	Added logic to adjust cursor position based on `yPointer`
`libs/windy-sounding/src/containers/containers.tsx`	Introduced `moveCursor` function and updated event handlers
`libs/windy-sounding/src/styles.less`	Added style rule for `.bottom`'s `text` element
`libs/windy-sounding/upload.sh`	Updated script to create plugin archive, set GitHub repository info, and publish the plugin using cURL

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EnvFile as .env File
    participant FavoritesComp as Favorites Component
    participant WindProfileComp as WindProfile Component
    participant Container as Container Component
    participant WindyAPI as Windy API

    rect rgba(200, 200, 255, 0.2)
    note over User, Container: Initial Setup
    User ->> EnvFile: Add WINDY_API_KEY
    User ->> GitIgnore: Update .gitignore
    end

    rect rgba(255, 200, 200, 0.2)
    note over FavoritesComp, WindProfileComp: Component Updates
    User ->> FavoritesComp: Update render logic for favorites
    FavoritesComp ->> FavoritesComp: Calculate & display current location
    User ->> WindProfileComp: Adjust cursor position logic
    WindProfileComp ->> Container: Update cursor based on pointer
    end

    rect rgba(200, 255, 200, 0.2)
    note over Container, WindyAPI: Plugin Publishing
    User ->> UploadScript: Run upload.sh script
    UploadScript ->> WindyAPI: Upload plugin with API key
    WindyAPI ->> User: Confirm upload completion
    end

Poem

🐰 In the world of code so vast, Changes come and changes pass. Nodes ignored, cursors quick, Scaling heights with a simple click. API key, upload with flair, Windy winds now everywhere. 🎈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying flyxc with Cloudflare Pages

Latest commit:	`e0a5bd3`
Status:	✅ Deploy successful!
Preview URL:	https://42476fd8.flyxc.pages.dev
Branch Preview URL:	https://rtk.flyxc.pages.dev

View logs

vicb / flyXC