vicb / flyXC

One stop shop web app for paraglider pilots. Plan, visualize, and track your flights.
https://flyxc.app
MIT License
97 stars 34 forks source link

Add the GMaps API key for APPI #284

Closed vicb closed 3 months ago

vicb commented 3 months ago

Summary by CodeRabbit

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

πŸ”Ž Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13337747](https://dashboard.gitguardian.com/workspace/65432/incidents/13337747?occurrence=162577502) | Triggered | Google API Key | 955263e41c0657576f3661b775eee7d3beba5526 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyXC/commit/955263e41c0657576f3661b775eee7d3beba5526#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81L21) | | [13337748](https://dashboard.gitguardian.com/workspace/65432/incidents/13337748?occurrence=162577503) | Triggered | Google API Key | 955263e41c0657576f3661b775eee7d3beba5526 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyXC/commit/955263e41c0657576f3661b775eee7d3beba5526#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81L22) | | [13337748](https://dashboard.gitguardian.com/workspace/65432/incidents/13337748?occurrence=162577504) | Triggered | Google API Key | 955263e41c0657576f3661b775eee7d3beba5526 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyXC/commit/955263e41c0657576f3661b775eee7d3beba5526#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R22) | | [13337749](https://dashboard.gitguardian.com/workspace/65432/incidents/13337749?occurrence=162577500) | Triggered | Google API Key | 955263e41c0657576f3661b775eee7d3beba5526 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyXC/commit/955263e41c0657576f3661b775eee7d3beba5526#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81L19) | | [13337750](https://dashboard.gitguardian.com/workspace/65432/incidents/13337750?occurrence=162577505) | Triggered | Google API Key | 955263e41c0657576f3661b775eee7d3beba5526 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyXC/commit/955263e41c0657576f3661b775eee7d3beba5526#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81L20) | | [13337751](https://dashboard.gitguardian.com/workspace/65432/incidents/13337751?occurrence=162577501) | Triggered | Google API Key | 955263e41c0657576f3661b775eee7d3beba5526 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyXC/commit/955263e41c0657576f3661b775eee7d3beba5526#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R24) | | [13337751](https://dashboard.gitguardian.com/workspace/65432/incidents/13337751?occurrence=162577506) | Triggered | Google API Key | 955263e41c0657576f3661b775eee7d3beba5526 | apps/fxc-front/.env.production | [View secret](https://github.com/vicb/flyXC/commit/955263e41c0657576f3661b775eee7d3beba5526#diff-f9c1f4afe7937321d7fc9a1cdd173c5db1970e009aa81f54ff31caed8b845d81R23) |
πŸ›  Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/googleaiza#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent update enhances the application's environment configuration, introducing API key entries for two new domains, "flyappi.org" and "appipower.org". This integration broadens the application's capabilities, enabling it to support additional services while preserving existing functionality and ensuring backward compatibility.

Changes

Files Change Summary
apps/fxc-front/.env.production Added API key entries for "flyappi.org" and "appipower.org" alongside existing configuration.
apps/fxc-front/vite.config.mts Replaced minifyHTML plugin with literalsHtmlCssMinifier for HTML minification in the build process.
package.json Updated various dependencies, including multiple @nx packages from 19.5.3 to 19.5.6, and other packages for bug fixes and enhancements.

Poem

In the meadow where bunnies hop,
New domains are here, we won’t stop!
With keys to unlock more fun,
Flyappi and Appipower, we’ve just begun!
Hopping with joy, let’s celebrate,
Code brings us all together, isn’t it great? πŸ‡βœ¨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sourcery-ai[bot] commented 3 months ago

πŸ§™ Sourcery has finished reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying flyxc with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24940f8
Status: βœ…  Deploy successful!
Preview URL: https://506a5db6.flyxc.pages.dev
Branch Preview URL: https://appi.flyxc.pages.dev

View logs