search

vickramravichandran / angular-auto-complete

AngularJS auto complete plugin
http://demo.vickram.me/angular-auto-complete
Other
28 stars 31 forks source link

CSS is too specific #26

Open craiggoldstone opened 5 years ago

craiggoldstone commented 5 years ago

CSS is too specific, it's overkill. It is enough to simply use classes. Or even better, use BEM.

Current: bad

div.auto-complete-container ul.auto-complete-results li.auto-complete-item {}

Proposal 1: good - remove over-specific css, simply use classes)

.auto-complete-container .auto-complete-results .auto-complete-item {}

Proposal 2: better - remove nested styles, it has no use here)

.auto-complete-container {}
.auto-complete-results {}
.auto-complete-item {}

Proposal 3: best - use BEM naming convention)

.auto-complete {}
.auto-complete__results {}
.auto-complete__item {}

I'm happy to submit a PR if desired

vickramravichandran commented 5 years ago

Yes, please submit a PR with the BEM convention.