Completion alignment improvements

nomothetis commented 11 years ago

This branch:

Properly aligns the completion window to the beginning of the string, across font size changes.
Shows the window above or below the current line, depending on available space.
Never takes up more than half the sreen with the completions; scrolling is enabled to see more.
Changes the colors of the currently selected completion to make it more legible.

Shadowfiend commented 11 years ago

This PR includes #53, so I think I'm going to close that one and just take care of both here.

@jordwalke, this is the new place to look at this work if you're looking for it :)

Shadowfiend commented 11 years ago

I fixed up the PR title—if you created this using the command-line hub utility, keep in mind that the first line is the PR title, and the subsequent ones the description :)

Shadowfiend commented 11 years ago

Werps. This seems to be happening at times:

2013-08-26 11:15:11.506 Vico[50802:303] *** -[__NSArrayM objectAtIndex:]: index 18446744073709551605 beyond bounds [0 .. 1]
2013-08-26 11:15:11.516 Vico[50802:303] (
    0   CoreFoundation                      0x00007fff852d5b06 __exceptionPreprocess + 198
    1   libobjc.A.dylib                     0x00007fff86ae53f0 objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff852728ec -[__NSArrayM objectAtIndex:] + 252
    3   Vico                                0x00000001000865c6 -[ViCompletionController selectionShouldChangeInTableView:] + 230
    4   AppKit                              0x00007fff8d63f9aa -[NSTableView _userCanChangeSelection] + 50
    5   AppKit                              0x00007fff8d63f7cd -[NSTableView _userSelectableRowIndexesForProposedSelection:userCanAlreadyChangeSelection:] + 167
    6   AppKit                              0x00007fff8d63f6ea -[NSTableView _userCanSelectSingleRow:] + 176

Haven't tracked it down yet, just a heads up. Doesn't crash anything, just… Happens.

vicoapp / vico

Completion alignment improvements #56