search

vicoapp / vico

Mac Programmers Text Editor
http://www.vicoapp.com/
657 stars 89 forks source link

Load github bundles from all pages #6

Closed itsgg closed 11 years ago

itsgg commented 12 years ago

Github API now paginates repository list (default page size = 30). https://api.github.com/users/textmate/repos

Currently vico bundle preference view will only load bundles listed in the first page.

We have to load the number of public repositories from https://api.github.com/users/textmate and then load the bundles browsing through all the pages.

rainkinz commented 12 years ago

Does this explain why when trying to refresh the repositories in Preferences > Bundles, it fails with the message

"Failed to parse data for user vicoapp"

itsgg commented 12 years ago

The parsing issue should be fixed in the master branch On Jul 13, 2012 8:01 PM, "rainkinz" < reply@reply.github.com> wrote:

Does this explain why when trying to refresh the repositories in Preferences > Bundles, it fails with the message

"Failed to parse data for user vicoapp"

Reply to this email directly or view it on GitHub: https://github.com/vicoapp/vico/issues/6#issuecomment-6964596

rainkinz commented 12 years ago

ah, ok, thanks. I'll try building it and test. cheers

Shadowfiend commented 11 years ago

This is fixed, as per PR #39.