search

vicoapp / vico

Mac Programmers Text Editor
http://www.vicoapp.com/
657 stars 89 forks source link

Flippety Floppety Floo: Handle icon flippedness correctly everywhere. #85

Closed Shadowfiend closed 9 years ago

Shadowfiend commented 9 years ago

There was a call to flip images being rendered in ViToolbarPopUpButtonCell that was breaking all drawing using drawAtPoint:, which we switched to in order to avoid deprecation warnings on compositeToPoint:.

This removes all weird flippedness handling in the code and the original flip in the final drawing component.

Fixes #84 .

farmdawgnation commented 9 years ago

This is much better. Though the icons are def not oriented correctly...

screen shot 2014-12-13 at 12 22 39 pm

And the X's appear to be a bit south of the midline of the tab title

screen shot 2014-12-13 at 12 22 29 pm

Shadowfiend commented 9 years ago

Need to see why things are trying to be flipped when they shouldn't be… I suspect the X is also flipped and that's why its alignment is off.

Shadowfiend commented 9 years ago

Yeah, looks like that “fix” was a bad fix all around. Sweet -.-

jordwalke commented 9 years ago

So should this pull request be closed (does it not fix the issue?)

Shadowfiend commented 9 years ago

Probably :/