search

videogular / videogular2

The HTML5 video player for Angular 2
https://videogular.github.io/videogular2-showroom/#/
MIT License
672 stars 211 forks source link

Angular 9+, ivy, node > 11 #886

Closed kzimny closed 4 years ago

kzimny commented 4 years ago

@Elecash is there any chance to keep the project alive? Many users awaiting an update compatible with angular 9+, at the moment only node < v.11 is required. Seems that you are not interested to maintain the videogular2 project and npm package. #872

max1weber commented 4 years ago

npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! videogular2@0.0.0-semantically-released build: ngc npm ERR! Exit status 1

Elecash commented 4 years ago

@kzimny I would like to, but I'm not using it anymore and I can't find time to maintain it. I think that the best would be that someone that is actively using it wants to take control of the project.

kzimny commented 4 years ago

@sliceofbytes : FYI.

max1weber commented 4 years ago

@kzimny I would like to, but I'm not using it anymore and I can't find time to maintain it. I think that the best would be that someone that is actively using it wants to take control of the project.

Hi maybe we can pick up this project and take it further?

also the webpage https://videogular.github.io/videogular2/

Elecash commented 4 years ago

@max1weber @kzimny I can give you access to the project as maintainers if you want :)

Isaac-1010 commented 4 years ago

I would love to maintain this project as well.

itayperry commented 4 years ago

I'm having the same issue.. any recommendations?

Elecash commented 4 years ago

@itzikgili check your inbox, I invited you to the organization.

IxquitilisSaid commented 4 years ago

@Elecash could I offer to maintain it also? We use it a lot in our project and since we are upgrading to v9, it's only fair that I contribute to a project that adds value to ours.

Already forked and working on the upgrade to glorious v9

Elecash commented 4 years ago

@IxquitilisSaid very happy to send you an invite too, thanks for the help :)

muhammed671 commented 4 years ago

hi, is there any new news regarding v9? Im also interested in this project

IxquitilisSaid commented 4 years ago

@muhammed671 I'm currently working on the v9 upgrade! Before Wednesday we should have an Ivy compatible package published so look forward to that!

Also thank you for taking interest in our project 😄

nathanbabcock commented 4 years ago

@IxquitilisSaid very excited to heard that :D

And thank you for taking the lead on this Angular 9 upgrade, it is a hard problem to solve for many teams at my company.

lcatania commented 4 years ago

hi guys , any news how the upgrade is going?

muhammed671 commented 4 years ago

@muhammed671 I'm currently working on the v9 upgrade! Before Wednesday we should have an Ivy compatible package published so look forward to that!

Also thank you for taking interest in our project

Any new things?

tiberiumihai commented 4 years ago

@muhammed671 I'm currently working on the v9 upgrade! Before Wednesday we should have an Ivy compatible package published so look forward to that!

Also thank you for taking interest in our project 😄

Hi. Is there any update on this one? Can I help with something? Just let me know. Thanks.

IxquitilisSaid commented 4 years ago

So, the new project is done (no failing tests, huzzah!) but hasn't yet been published and the repo is still private. I pretty much rebuilt the structure of it and slimmed the size of the dist.

That being said, what's currently missing is:

If any of you want to do a test-drive, update the docs, catch some bugs, etc, please let me know!

djabif commented 4 years ago

Has anyone tried to fork the project and add ngcc to the postinstall script as mentioned in https://angular.io/guide/ivy#ivy-and-libraries?

Auha commented 4 years ago

Would it be possible to move ngx-videogular into the videogular org? Or at least have comments or a part of the README pointing to the correct repo. Also, I noticed that the last update of the ngx-videogular has been three months ago. Is there a more recent update?

Elecash commented 4 years ago

@Auha it is in the videogular org but is not yet public, we will open it as soon as it's ready.

Claudio504 commented 4 years ago

Hey @IxquitilisSaid, I'm interested in the Angular9-compatible version. What can I do to help with the tests?

Auha commented 4 years ago

@Elecash I would to be able to test it out as well. Although my use case currently is pretty simple, but it could lead to more interesting things in the future.

baptistelaget commented 4 years ago

Working on a relatively fresh implementation of Videogular with Angular 9. Let me know how I can help with tests.

pacificsharma commented 4 years ago

By when will the videangular with Angular 9 be released?

shubham-vunet commented 4 years ago

By when will the videangular with Angular 9 be released?

+1

nathanbabcock commented 4 years ago

@IxquitilisSaid Is the Angular9 Videogular compatibility work complete?

DDeis commented 4 years ago

Hi @IxquitilisSaid, it's been nearly two months, can we have updated info about ngx-videogular progress ? Also is there anything we can do to help ?

IxquitilisSaid commented 4 years ago

Yeah sorry, was busy with personal stuff and work but it's been ready for a while now. Recently I refactored it so we use secondary entry points (like angular/material or cdk).

The thing is that I've been waiting for 2 weeks now on NPM support to resolve a dispute regarding someone squatting on the @ videogular org so I can publish it.

So, yeah let me give you guys some options to vote on (we are a democracy after all) since y'all want the new stuff:

👍 = Publish it as '@videoglr/ngx-videogular' 👎 = Wait for the dispute so I can publish it as '@videogular/ngx-videogular' 🚀 = Suggestions?

Auha commented 4 years ago

Yeah, sadly I would say it would be best to deal with the squatter. Is there any way the community can contribute in helping out? Any person we can voice ourselves to?

vaughnmuirhead commented 4 years ago

Very keen to see a resolution on this. Anything I can do to help?

IxquitilisSaid commented 4 years ago

@vaughnmuirhead reckon not, buddy (unless you work for NPM support lol). But I have messaged them again 5 minutes ago.

Y'all have my word that AS SOON as the ownership is transferred, I'm hitting that publish button faster than Sanic

IxquitilisSaid commented 4 years ago

https://www.npmjs.com/package/@videogular/ngx-videogular And we live!

max1weber commented 4 years ago

Yeah,

Thanks!

Marc

Get Outlook for Androidhttps://aka.ms/ghei36

From: Jaime Oliveira notifications@github.com Sent: Saturday, July 4, 2020 2:49:47 AM To: videogular/videogular2 videogular2@noreply.github.com Cc: Marc Weber max1_weber@hotmail.com; Mention mention@noreply.github.com Subject: Re: [videogular/videogular2] Angular 9+, ivy, node > 11 (#886)

https://www.npmjs.com/package/@videogular/ngx-videogular And we live!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/videogular/videogular2/issues/886#issuecomment-653702334, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADCPGO3OWWWOAVTWFPMFETRZZ4CXANCNFSM4LCDUBVA.

arcovoltaico commented 4 years ago

The How To start on https://www.npmjs.com/package/@videogular/ngx-videogular is 404. Also the installation of this library does not provide the videogular modules needed for app.module . What am I missing? thanks!

IxquitilisSaid commented 4 years ago

Good morning @arcovoltaico! I updated the Docs with the Suffixed names 😄 Also, the npm page might have bugged for you so please check again.

If you still find yourself lost, feel free to open an issue at https://github.com/videogular/ngx-videogular/issues so we can make the Documentation better and/or give you hand.

Have an awesome day! 😎

arcovoltaico commented 4 years ago

Hi, Sorry to bother you, but https://github.com/videogular/ngx-videogular still has two dead links 404 on the readme, even the stackblitz is not using the dependency. No hint about how to install it l. Also I have no clue about "I updated the Docs with the Suffixed names". Am I on parallel dimension ? Cheers

saeed-abdul-rahim commented 4 years ago

This is not working for me .... It throws error on all imported modules: Below is one of them: This likely means that the library (@videogular/ngx-videogular/buffering) which declares BufferingModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

I've imported: import { CoreModule } from '@videogular/ngx-videogular/core'; import { ControlsModule } from '@videogular/ngx-videogular/controls'; import { OverlayPlayModule } from '@videogular/ngx-videogular/overlay-play'; import { BufferingModule } from '@videogular/ngx-videogular/buffering';

IxquitilisSaid commented 4 years ago

@saeed-abdul-rahim does your package.json have "postinstall": "ngcc"?

pacificsharma commented 4 years ago

The How To start on https://www.npmjs.com/package/@videogular/ngx-videogular is 404. Also the installation of this library does not provide the videogular modules needed for app.module . What am I missing? thanks!

Yes, getting 404 on getting started guide.

Obehi commented 4 years ago

This is not working for me .... It throws error on all imported modules: Below is one of them: This likely means that the library (@videogular/ngx-videogular/buffering) which declares BufferingModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

I've imported: import { CoreModule } from '@videogular/ngx-videogular/core'; import { ControlsModule } from '@videogular/ngx-videogular/controls'; import { OverlayPlayModule } from '@videogular/ngx-videogular/overlay-play'; import { BufferingModule } from '@videogular/ngx-videogular/buffering';

Im also getting this. Have tried with and without "postinstall": "ngcc"