videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.53k stars 425 forks source link

fix: demo page representation selector #1416

Closed adrums86 closed 1 year ago

adrums86 commented 1 year ago

Description

The VHS demo page representation selector was not allowing the user to select the first or 0 indexed representation in the list.

Specific Changes proposed

Remove the !selectedIndex check and change the expected index to < 0 for "no element selected". See: https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedIndex

Requirements Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1416 (5043a24) into main (de183c8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          41       41           
  Lines       10145    10145           
  Branches     2351     2351           
=======================================
  Hits         8680     8680           
  Misses       1465     1465           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more