search

videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.53k stars 425 forks source link

HttpStreaming v2.16.3 not build successfully #1491

Closed MCab93 closed 8 months ago

MCab93 commented 8 months ago

Description

Hello, regarding previsously reported issue of https://github.com/videojs/http-streaming/pull/1463#issuecomment-1884058727 - when I checkout version 2.16.3 changes from that PR are not present. Checking build https://github.com/videojs/http-streaming/actions/runs/7592761058/job/20682472936 - failed, therefore the changes are missing. Can you please rerun the build / make new version of 2x branch, so the changes are present ? Thank you

Sources

https://github.com/videojs/http-streaming/actions/runs/7592761058/job/20682472936

Steps to reproduce

Check https://github.com/videojs/http-streaming/actions/runs/7592761058/job/20682472936

Results

Changes from https://github.com/videojs/http-streaming/pull/1463#issuecomment-1884058727 are not in build 2.16.3

Expected

Please describe what you expected to happen that did not happen in the description.

Error output

Run softprops/action-gh-release@v1 🤔 Pattern 'dist/*/.css' does not match any files. 👩‍🏭 Creating new GitHub release for tag v2.16.3... ⚠️ GitHub release failed with status: 404 undefined retrying... (2 retries remaining) 👩‍🏭 Creating new GitHub release for tag v2.16.3... ⚠️ GitHub release failed with status: 422 [{"resource":"Release","code":"already_exists","field":"tag_name"}] retrying... (1 retries remaining) 👩‍🏭 Creating new GitHub release for tag v2.16.3... ⚠️ GitHub release failed with status: 422 [{"resource":"Release","code":"already_exists","field":"tag_name"}] retrying... (0 retries remaining) ❌ Too many retries. Aborting... Error: Too many retries.

videojs-http-streaming version

videojs-http-streaming 2.16.3

welcome[bot] commented 8 months ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

adrums86 commented 8 months ago

Hi @MCab93 the release step may have failed but it did publish to npm https://www.npmjs.com/package/@videojs/http-streaming/v/2.16.3 and a github release was created https://github.com/videojs/http-streaming/releases/tag/v2.16.3. Checking the commit history against 2.x branch and I see the changes in there https://github.com/videojs/http-streaming/commits/2.x/. I would make sure you're pulling from the correct branch, 2.x not 2x and/or the package versions are correct. I just pulled the latest from 2.x and the changes are definitely in there.