videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.53k stars 425 forks source link

fix: Ensure native segment metadata track has mode hidden #1550

Open mister-ben opened 3 weeks ago

mister-ben commented 3 weeks ago

Description

When using native text tracks, the segment metadata track was being created with mode disabled. This meant it wouldn't trigger cuechange events, but also Chrome (at least) does not add cues to disabled tracks. This change makes the track start out hidden.

Specific Changes proposed

Requirements Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@9f1c4ad). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1550 +/- ## ======================================= Coverage ? 84.06% ======================================= Files ? 43 Lines ? 11628 Branches ? 2604 ======================================= Hits ? 9775 Misses ? 1853 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.