Open mister-ben opened 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
main@9f1c4ad
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
When using native text tracks, the segment metadata track was being created with mode
disabled
. This meant it wouldn't triggercuechange
events, but also Chrome (at least) does not add cues to disabled tracks. This change makes the track start outhidden
.Specific Changes proposed
hidden
addSegmentMetadataCue_
is made noop in the tests.Requirements Checklist