search

videojs / mpd-parser

https://videojs.github.io/mpd-parser/
Other
78 stars 54 forks source link

[#156] fix: DASH content protection schemeIdUri as lowercase #157

Closed mhk-etn closed 2 years ago

mhk-etn commented 2 years ago

Original issue

DASH ContentProtection schemeIdUri attributes are converted to lowercase on input to avoid keySystems mismatch since UUIDs should be handled case-insensitively.

mhk-etn commented 2 years ago

@gkatsev is there something left for me to do, or are we just waiting before someone else merges/builds it? Just to be sure, this is my 1st PR.

codecov[bot] commented 2 years ago

Codecov Report

Merging #157 (2d35fb4) into main (fb0d298) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files          18       18           
  Lines         772      773    +1     
  Branches      240      241    +1     
=======================================
+ Hits          728      729    +1     
  Misses         44       44
Impacted Files Coverage Δ
src/inheritAttributes.js 97.35% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb0d298...2d35fb4. Read the comment docs.