videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
37.96k stars 7.44k forks source link

`Sass` deprecations #8876

Open rtritto opened 3 weeks ago

rtritto commented 3 weeks ago

Description

After I updated sass-embedded to version 1.79.3

Deprecation [legacy-js-api]: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api
Deprecation Warning: lighten() is deprecated. Suggestions:

color.scale($color, $lightness: 41.6584158416%)
color.adjust($color, $lightness: 33%)

More info: https://sass-lang.com/d/color-functions

  ╷
9 │ $secondary-background-color: lighten($primary-background-color, 33%) !default;
  │                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
    file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/_private-variables.scss 9:30  @import
    file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/video-js.scss 3:9             @import
    file:///C:/<PROJECT_PATH>/src/scss/videojs.scss 2:9                                   root stylesheet

Reduced test case

NA

Steps to reproduce

  1. Install sass or sass-embedded
  2. Add @import 'video.js/src/css/video-js.scss'; in the scss file and import it.
  3. See the logs

Errors

No response

What version of Video.js are you using?

8.18.1

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Firefox 129

What OS(es) and version(s) does this occur with?

Windows 11

rtritto commented 1 week ago

FYI @mister-ben @gkatsev