search

vierge-noire / cakephp-fixture-factories

CakePHP Fixture Factories
https://vierge-noire.github.io/
MIT License
83 stars 21 forks source link

phpdoc @param types of `FactoryAwareTrait::getFactory()` is too narrower than acceptable types #218

Closed ckbx-cakebox closed 1 year ago

ckbx-cakebox commented 1 year ago

The second and trailing arguments of FactoryAwareTrait::getFactory() can internally accept as same types as the BaseFactory::make(), but currently declared as a sequence of array[]|string in phpdoc. It cannot accept even the simple associative array, that is one of the main use cases.

pabloelcolombiano commented 1 year ago

Thank you for the contribution!