search

vigetlabs / ca11y

A lightweight accessible dependency-free datepicker
http://code.viget.com/ca11y
26 stars 6 forks source link

Dna/formatter fix #39

Closed averyvery closed 8 years ago

averyvery commented 8 years ago

@solomonhawk @greypants addressing the issue here:

https://github.com/vigetlabs/ca11y/commit/a9bf9f46d48d68f2e9e3c81921a2312bf7bc52b7#commitcomment-16405677

Basically, I'm using the names formatter and parser to mean the callbacks that perform these operations, and letting parse remain an array (the way it is supposed to work). Before this change, options.format was unusable because one function expected an array, and another expected a function.

greypants commented 8 years ago

:+1: :+1:

Whoops. That's what I get for not running the tests (or writing any). I forgot @solomonhawk had written them.

Privia has made me better. I will test all the things.

averyvery commented 8 years ago

The tests worked (they verified that "format" was a function), it was just that the lib didn't. I think this was more a case of not having an example/demo that used the option. Anyhow, fixed now!

On Tuesday, March 1, 2016, Dan Tello notifications@github.com wrote:

[image: :+1:] [image: :+1:]

Whoops. That's what I get for not running the tests (or writing any). I forgot @solomonhawk https://github.com/solomonhawk had written them.

Privia has made me better. I will test all the things.

— Reply to this email directly or view it on GitHub https://github.com/vigetlabs/ca11y/pull/39#issuecomment-190723437.

Doug Avery Front-End Development Director

703.891.0670 x138 720.666.3852 m viget.com http://www.google.com/url?q=http%3A%2F%2Fviget.com&sa=D&sntz=1&usg=AFrqEzcM3JYXwowZdGV1yX2CD2NWL_AHOA

This email may include confidential information. Please do not share unless we agree otherwise.