search

vikejs / vike-node

🔨 Node integration for Vike
MIT License
23 stars 3 forks source link

refactor: use node protocol on imports #19

Closed rtritto closed 1 month ago

brillout commented 1 month ago

Curious: what's the rationale for doing this?

rtritto commented 1 month ago

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-node-protocol.md

brillout commented 1 month ago

So it's only about style, right?

The style should be determined by the maintainer, not by contributors. Thus closing. (Personally, I'm in favor of this rule, but it isn't my role to take that decision. It should be @nitedani that takes the decision in that regard.)

It's best when contributors focus on bugs or feature requests, while leaving stylistic decisions to the maintainers.

rtritto commented 1 month ago

It's a best practice to get more readability and a standard used by the Node.js (documentation) and the community. Have no sense to reject a simple and completed PR because focus is on other side. Projects should receive all the help they can get especially since they are still under the (early) development stage.

brillout commented 1 month ago

I do personally agree it's a slightly better. But, again, it's best when it's the lead maintainer that takes these kind of decisions which are more often than not subjective. For example, your PR introduces a merge conflict to Joël's PR. (That's actually why I would reject such PR on Vike core: I wouldn't want a PR to introduce a merge conflict to other PRs for merely a stylistic change.)

It's also best if contributors trust maintainers and let maintainers lead. So I'll ask you to be a little bit careful about that. Thank you.