search

vikejs / vike

🔨 Flexible, lean, community-driven, dependable, fast Vite-based frontend framework.
https://vike.dev
MIT License
4.39k stars 352 forks source link

fix: improve `injectScriptsAt` condition handling #1857

Closed phonzammi closed 2 months ago

phonzammi commented 2 months ago

fix #1856

@brillout, This fix addresses issue #1856. Please feel free to reject this if you believe there is a better approach to resolve the issue.

brillout commented 2 months ago

That makes sense. How about HTML_BEGIN instead of HTML_END?

brillout commented 2 months ago

That makes sense. How about HTML_BEGIN instead of HTML_END?

I'm sorry, what do you mean?

@phonzammi I mean that:

- return 'HTML_BEGIN'
+ return 'HTML_END'
phonzammi commented 2 months ago

That works too. I just prefer using HTML_BEGIN. We can change it if you prefer to.

brillout commented 2 months ago

I've improved the comments.

brillout commented 2 months ago

I'll pre-release in a moment.

phonzammi commented 2 months ago

Thank you, no rush 👍

brillout commented 2 months ago

Released in 0.4.195.