brillout
commented
2 weeks ago :+1: Nice, looking forward to try your new version. I get some build errors:
/code/vike/packages/eject (pr/1957-Eject$) pnpm run build
> eject@0.0.1 build /home/rom/code/vike/packages/eject
> tsc
src/command.ts:25:3 - error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
25 console.log('Ejected dependencies:', successFullEjections)
~~~~~~~
src/git.ts:1:26 - error TS2307: Cannot find module 'child_process' or its corresponding type declarations.
1 import { execSync } from 'child_process'
~~~~~~~~~~~~~~~
src/index.ts:16:11 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
16 cli.parse(process.argv.length === 2 ? [...process.argv, '--help'] : process.argv)
~~~~~~~
src/index.ts:16:43 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
16 cli.parse(process.argv.length === 2 ? [...process.argv, '--help'] : process.argv)
~~~~~~~
src/index.ts:16:69 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
16 cli.parse(process.argv.length === 2 ? [...process.argv, '--help'] : process.argv)
~~~~~~~
src/index.ts:18:1 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
18 process.on('unhandledRejection', (rejectValue) => {
~~~~~~~
src/index.ts:18:35 - error TS7006: Parameter 'rejectValue' implicitly has an 'any' type.
18 process.on('unhandledRejection', (rejectValue) => {
~~~~~~~~~~~
src/log.ts:4:3 - error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
4 console.log(chalk.green(message, optionalParams))
~~~~~~~
src/log.ts:8:3 - error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
8 console.log(chalk.red(message, optionalParams))
~~~~~~~
src/log.ts:12:3 - error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
12 console.log(chalk.blue(message, optionalParams))
~~~~~~~
src/log.ts:16:3 - error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
16 console.log(chalk.yellow(message, optionalParams))
~~~~~~~
src/system.ts:1:25 - error TS2307: Cannot find module 'path' or its corresponding type declarations.
1 import { resolve } from 'path'
~~~~~~
src/system.ts:2:16 - error TS2307: Cannot find module 'fs' or its corresponding type declarations.
2 import fs from 'fs'
~~~~
src/system.ts:3:26 - error TS2307: Cannot find module 'child_process' or its corresponding type declarations.
3 import { execSync } from 'child_process'
~~~~~~~~~~~~~~~
src/system.ts:51:17 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
51 const agent = process.env.npm_config_user_agent
~~~~~~~
src/system.ts:61:7 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
61 if (process.env.npm_execpath && process.env.npm_execpath.endsWith('yarn.js')) {
~~~~~~~
src/system.ts:61:35 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
61 if (process.env.npm_execpath && process.env.npm_execpath.endsWith('yarn.js')) {
~~~~~~~
src/system.ts:66:7 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
66 if (process.env.npm_command) {
~~~~~~~
src/system.ts:71:18 - error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
71 const parent = process.env._
~~~~~~~
Found 19 errors in 5 files.
Errors Files
1 src/command.ts:25
1 src/git.ts:1
5 src/index.ts:16
4 src/log.ts:4
8 src/system.ts:1
ELIFECYCLE Command failed with exit code 2.
snake-py
Somehow it closed my open PR after I had to reset my fork to Vike's current state.
@brillout I think I implemented all of your last comments. Sorry that I took so long to work on this. How did you test, that you came to this commit?
If I use this package like here, I get this commit.
See old PR.