search

vimalavinisha / angular2-google-chart

Angular 2 google chart
MIT License
59 stars 45 forks source link

Fix for angular2 RC with webpack build system #5

Closed mlessio closed 8 years ago

mlessio commented 8 years ago

Here is a couple of fixes allowing the library to work under webpack compiling and uglyfying.

Without those fixes it was throwing "EXCEPTION: No Directive annotation found on GoogleChart" in a production enviroment.

vimalavinisha commented 8 years ago

Hi,

 Thanks for your review. Now angular2-google-chart  support angular 2.0.0-rc.3 version.

Thanks.

mlessio commented 8 years ago

Hi!

No problem at all.

It would be nice if you did a pull from my fork for showing my mods inside your repo. But it doesn't matter.

Bye

2016-06-29 8:39 GMT+02:00 vimalavinisha notifications@github.com:

Closed #5 https://github.com/vimalavinisha/angular2-google-chart/pull/5.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vimalavinisha/angular2-google-chart/pull/5#event-707327326, or mute the thread https://github.com/notifications/unsubscribe/ADP6n6D59FESU6fBzs9P_mLhVd6tB5Rzks5qQhM2gaJpZM4I_11k .