vime-js / vime

Customizable, extensible, accessible and framework agnostic media player. Modern alternative to Video.js and Plyr. Supports HTML5, HLS, Dash, YouTube, Vimeo, Dailymotion...
https://vimejs.com
MIT License
2.78k stars 152 forks source link

bug: Not running with angular 12 #210

Open jbjhjm opened 3 years ago

jbjhjm commented 3 years ago

Bug Report

Vime version:

5.0.31

Current behavior:

Initialization using Angualr 12 will fail with error:

Error: Failed to execute 'define' on 'CustomElementRegistry': parameter 2 is not of type 'Function'.

Expected behavior:

Should work.

Steps to reproduce:

Minimal reproduction here: (Open the console to see error) https://stackblitz.com/edit/vime-muted-bug?file=src/app/app.component.html

AmerAlahmar commented 3 years ago

This's happening to me as well, I have a project running with angular-common ~12.1.3.

When I try to install Vime using npm npm i @vime/angular, I get the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: project-name@0.0.0
npm ERR! Found: @angular/common@12.1.5
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~12.1.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^11.0.4" from @vime/angular@5.0.33
npm ERR! node_modules/@vime/angular
npm ERR!   @vime/angular@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/username/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/username/.npm/_logs/2021-08-24T12_07_38_184Z-debug.log
jbjhjm commented 3 years ago

@AmerAlahmar as anguar supports web components when adding CUSTOM_ELEMENTS_SCHEMA, I decided to just skip using the added overhead and complexity of the angular adapter and use the standard vime components. Suggest you to do the same, think it is the better approach.